-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Collision monitor toggle bt plugin #5532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collision monitor toggle bt plugin #5532
Conversation
Signed-off-by: David G <david.randommail1@gmail.com>
Signed-off-by: David G <david.randommail1@gmail.com>
Signed-off-by: David G <david.randommail1@gmail.com>
Signed-off-by: David G <david.randommail1@gmail.com>
|
@DavidG-Develop, your PR has failed to build. Please check CI outputs and resolve issues. |
Signed-off-by: David G <david.randommail1@gmail.com>
|
@DavidG-Develop, your PR has failed to build. Please check CI outputs and resolve issues. |
|
@DavidG-Develop please heed CI and the merge conflict |
...behavior_tree/include/nav2_behavior_tree/plugins/action/toggle_collision_monitor_service.hpp
Show resolved
Hide resolved
|
This pull request is in conflict. Could you fix it @DavidG-Develop? |
Signed-off-by: DavidG-Develop <147402604+DavidG-Develop@users.noreply.github.com>
Signed-off-by: David G <david.randommail1@gmail.com>
|
@SteveMacenski the CI fails seem not to be bound to my code, the circleCI fails on |
|
Retriggering CI to check on those failures. Otherwise, see above with the action item(s) Edit: flake8 passed now - must have been a networking fluke |
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 11 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
CI is good now - just focus on the API & docs elements and can merge! |
|
@SteveMacenski The docs are waiting for this to be merged so I can grab a working link for the plugins list on the Navigation Plugins page, and I need to do the short migration guide (will be done tmrw). |
|
We cannot merge this without a docs PR unfortunately. They are merged as a pair. Understood on the API. I’ll file a ticket to do that once we merge. |
|
Ok yep understood, than for the link I will just fill it so it points to where the file should land so than |
|
Sounds good! It’s easy for forgetful maintainers (I.e. me) to merge this and then forget about the docs PR or the docs PR needs fixing and gets stale so the main code isn’t documented. This point of process is mostly for the benefit to keep things 1:1 synchronized. |
* add Bt pluging for toggle collision monitor service Signed-off-by: David G <david.randommail1@gmail.com> * Add test for btt plugin Signed-off-by: David G <david.randommail1@gmail.com> * Clean up test Signed-off-by: David G <david.randommail1@gmail.com> * Fix copyright in header Signed-off-by: David G <david.randommail1@gmail.com> * uncrustify Signed-off-by: David G <david.randommail1@gmail.com> * fix lint Signed-off-by: David G <david.randommail1@gmail.com> * fix circle ci Signed-off-by: David G <david.randommail1@gmail.com> --------- Signed-off-by: David G <david.randommail1@gmail.com> Signed-off-by: DavidG-Develop <147402604+DavidG-Develop@users.noreply.github.com>
* add Bt pluging for toggle collision monitor service Signed-off-by: David G <david.randommail1@gmail.com> * Add test for btt plugin Signed-off-by: David G <david.randommail1@gmail.com> * Clean up test Signed-off-by: David G <david.randommail1@gmail.com> * Fix copyright in header Signed-off-by: David G <david.randommail1@gmail.com> * uncrustify Signed-off-by: David G <david.randommail1@gmail.com> * fix lint Signed-off-by: David G <david.randommail1@gmail.com> * fix circle ci Signed-off-by: David G <david.randommail1@gmail.com> --------- Signed-off-by: David G <david.randommail1@gmail.com> Signed-off-by: DavidG-Develop <147402604+DavidG-Develop@users.noreply.github.com>
* add Bt pluging for toggle collision monitor service Signed-off-by: David G <david.randommail1@gmail.com> * Add test for btt plugin Signed-off-by: David G <david.randommail1@gmail.com> * Clean up test Signed-off-by: David G <david.randommail1@gmail.com> * Fix copyright in header Signed-off-by: David G <david.randommail1@gmail.com> * uncrustify Signed-off-by: David G <david.randommail1@gmail.com> * fix lint Signed-off-by: David G <david.randommail1@gmail.com> * fix circle ci Signed-off-by: David G <david.randommail1@gmail.com> --------- Signed-off-by: David G <david.randommail1@gmail.com> Signed-off-by: DavidG-Develop <147402604+DavidG-Develop@users.noreply.github.com>
Basic Info
Depends on #5493
Description of contribution in a few bullet points
Added bt plugin for toggling the collision monitor. The plugin wraps the BtServiceNode and calls the toggle service using
nav2_msgs::srv::Toggle. The toggle control is done using a boolean input port which defines if the cm should be enabled or disabled.Description of documentation updates required from your changes
Should be added to the Navigation plugins -> Behavior tree nodes -> Action plugin list
Description of how this change was tested
Wrote a test for it (used previous tests as template).
Tested also by implementing a rudimentary service that this plugin can call and adding this plugin into the default tree to be called.
Future work that may be required in bullet points
For Maintainers:
backport-*.