-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add toggle cm to simple commander API #5559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SteveMacenski
merged 5 commits into
ros-navigation:main
from
DavidG-Develop:toggle_cm_sc_api
Sep 29, 2025
Merged
Add toggle cm to simple commander API #5559
SteveMacenski
merged 5 commits into
ros-navigation:main
from
DavidG-Develop:toggle_cm_sc_api
Sep 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n test for consistency Signed-off-by: David G <david.randommail1@gmail.com>
Signed-off-by: David G <david.randommail1@gmail.com>
Contributor
Author
Signed-off-by: David G <david.randommail1@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
SteveMacenski
requested changes
Sep 29, 2025
Signed-off-by: David G <david.randommail1@gmail.com>
Signed-off-by: David G <david.randommail1@gmail.com>
SteveMacenski
approved these changes
Sep 29, 2025
Member
SteveMacenski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just waiting on CI
Member
|
Thanks @DavidG-Develop ! |
SakshayMahna
pushed a commit
to SakshayMahna/navigation2
that referenced
this pull request
Oct 4, 2025
* Add toggle cm to simple comander API, fix default toggle cm service in test for consistency Signed-off-by: David G <david.randommail1@gmail.com> * Fix pre commit, ament flake, add readme Signed-off-by: David G <david.randommail1@gmail.com> * add toggle msg to __init__.py Signed-off-by: David G <david.randommail1@gmail.com> * add error handling Signed-off-by: David G <david.randommail1@gmail.com> * add error handling for clear costmap functions Signed-off-by: David G <david.randommail1@gmail.com> --------- Signed-off-by: David G <david.randommail1@gmail.com>
silanus23
pushed a commit
to silanus23/navigation2
that referenced
this pull request
Oct 10, 2025
* Add toggle cm to simple comander API, fix default toggle cm service in test for consistency Signed-off-by: David G <david.randommail1@gmail.com> * Fix pre commit, ament flake, add readme Signed-off-by: David G <david.randommail1@gmail.com> * add toggle msg to __init__.py Signed-off-by: David G <david.randommail1@gmail.com> * add error handling Signed-off-by: David G <david.randommail1@gmail.com> * add error handling for clear costmap functions Signed-off-by: David G <david.randommail1@gmail.com> --------- Signed-off-by: David G <david.randommail1@gmail.com>
silanus23
pushed a commit
to silanus23/navigation2
that referenced
this pull request
Oct 11, 2025
* Add toggle cm to simple comander API, fix default toggle cm service in test for consistency Signed-off-by: David G <david.randommail1@gmail.com> * Fix pre commit, ament flake, add readme Signed-off-by: David G <david.randommail1@gmail.com> * add toggle msg to __init__.py Signed-off-by: David G <david.randommail1@gmail.com> * add error handling Signed-off-by: David G <david.randommail1@gmail.com> * add error handling for clear costmap functions Signed-off-by: David G <david.randommail1@gmail.com> --------- Signed-off-by: David G <david.randommail1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Added the service client to toggle collision monitor to the simple commander API.
Also, additionally fixed the default service name for the toggle collision monitor in the BT plugin test to ensure consistency).
Description of documentation updates required from your changes
Needs to be added to the commander docs (will open a pr to docs right away so it can be merged together)
Description of how this change was tested
Wrote a python script that calls the function for both on and off. Added to log to the service callback in the collision monitor to assure it is actually called (log not in the PR).
Future work that may be required in bullet points
For Maintainers:
backport-*.