Skip to content

Conversation

@DavidG-Develop
Copy link
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses #5493 #5532
Primary OS tested on Dockerized ubuntu
Robotic platform tested on TB4 sim
Does this PR contain AI generated software? AI assisted
Was this PR description generated by AI software? No

Description of contribution in a few bullet points

Added the service client to toggle collision monitor to the simple commander API.

Also, additionally fixed the default service name for the toggle collision monitor in the BT plugin test to ensure consistency).

Description of documentation updates required from your changes

Needs to be added to the commander docs (will open a pr to docs right away so it can be merged together)

Description of how this change was tested

Wrote a python script that calls the function for both on and off. Added to log to the service callback in the collision monitor to assure it is actually called (log not in the PR).


Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists
  • Should this be backported to current distributions? If so, tag with backport-*.
…n test for consistency

Signed-off-by: David G <david.randommail1@gmail.com>
Signed-off-by: David G <david.randommail1@gmail.com>
@DavidG-Develop
Copy link
Contributor Author

Signed-off-by: David G <david.randommail1@gmail.com>
@codecov
Copy link

codecov bot commented Sep 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Signed-off-by: David G <david.randommail1@gmail.com>
Signed-off-by: David G <david.randommail1@gmail.com>
Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just waiting on CI

@SteveMacenski SteveMacenski merged commit c747df5 into ros-navigation:main Sep 29, 2025
18 checks passed
@SteveMacenski
Copy link
Member

SteveMacenski commented Sep 29, 2025

Thanks @DavidG-Develop !

SakshayMahna pushed a commit to SakshayMahna/navigation2 that referenced this pull request Oct 4, 2025
* Add toggle cm to simple comander API, fix default toggle cm service in test for consistency

Signed-off-by: David G <david.randommail1@gmail.com>

* Fix pre commit, ament flake, add readme

Signed-off-by: David G <david.randommail1@gmail.com>

* add toggle msg to __init__.py

Signed-off-by: David G <david.randommail1@gmail.com>

* add error handling

Signed-off-by: David G <david.randommail1@gmail.com>

* add error handling for clear costmap functions

Signed-off-by: David G <david.randommail1@gmail.com>

---------

Signed-off-by: David G <david.randommail1@gmail.com>
silanus23 pushed a commit to silanus23/navigation2 that referenced this pull request Oct 10, 2025
* Add toggle cm to simple comander API, fix default toggle cm service in test for consistency

Signed-off-by: David G <david.randommail1@gmail.com>

* Fix pre commit, ament flake, add readme

Signed-off-by: David G <david.randommail1@gmail.com>

* add toggle msg to __init__.py

Signed-off-by: David G <david.randommail1@gmail.com>

* add error handling

Signed-off-by: David G <david.randommail1@gmail.com>

* add error handling for clear costmap functions

Signed-off-by: David G <david.randommail1@gmail.com>

---------

Signed-off-by: David G <david.randommail1@gmail.com>
silanus23 pushed a commit to silanus23/navigation2 that referenced this pull request Oct 11, 2025
* Add toggle cm to simple comander API, fix default toggle cm service in test for consistency

Signed-off-by: David G <david.randommail1@gmail.com>

* Fix pre commit, ament flake, add readme

Signed-off-by: David G <david.randommail1@gmail.com>

* add toggle msg to __init__.py

Signed-off-by: David G <david.randommail1@gmail.com>

* add error handling

Signed-off-by: David G <david.randommail1@gmail.com>

* add error handling for clear costmap functions

Signed-off-by: David G <david.randommail1@gmail.com>

---------

Signed-off-by: David G <david.randommail1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants