fix(build): add missing subagents and shared instructions to collection manifests#804
Merged
WilliamBerryiii merged 1 commit intomainfrom Feb 27, 2026
Merged
Conversation
…on manifests - add 5 RPI subagent dependencies to project-planning collection YAML - add shared hve-core-location instruction to design-thinking and experimental collections - update project-planning collection markdown with 4 missing agent descriptions - regenerate plugin outputs Fixes #802 🔧 - Generated by Copilot
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
agreaves-ms
approved these changes
Feb 27, 2026
bindsi
pushed a commit
that referenced
this pull request
Feb 27, 2026
…on manifests (#804) Collection manifests had gaps where parent agents declared subagent dependencies that were not listed in the corresponding `collections/*.collection.yml` files. The *project-planning* collection was missing five RPI subagent entries, the *design-thinking* and *experimental* collections were missing the shared *hve-core-location* instruction, and the *project-planning.collection.md* description was incomplete. This PR closed all identified gaps and regenerated affected plugin outputs. ## Description ### Collection YAML Manifest Completeness Five `kind: agent` entries were added to *project-planning.collection.yml* for **researcher-subagent**, **plan-validator**, **phase-implementor**, **rpi-validator**, and **implementation-validator**, all referencing canonical files in `.github/agents/hve-core/subagents/`. A `kind: instruction` entry for *hve-core-location.instructions.md* was added to both *design-thinking.collection.yml* and *experimental.collection.yml*. ### Collection Markdown Description *project-planning.collection.md* was expanded with four previously missing agent descriptions (**Product Manager Advisor**, **UX/UI Designer**, **System Architecture Reviewer**, and **RPI Agent**) and a new "Supporting subagents included" section with five subagent descriptions. Entries were reordered for logical grouping, and all bullets were normalized to the `- **Name** —` convention matching other collection markdown files. ### Plugin Output Regeneration All affected plugin outputs were regenerated via `npm run plugin:generate`. Three README files gained new table rows (*plugins/design-thinking/README.md*, *plugins/experimental/README.md*, *plugins/project-planning/README.md*), and seven new symlinks were created under `plugins/` directories pointing to canonical source files. ## Related Issue(s) Fixes #802 ## Type of Change Select all that apply: **Code & Documentation:** - [x] Bug fix (non-breaking change fixing an issue) - [ ] New feature (non-breaking change adding functionality) - [ ] Breaking change (fix or feature causing existing functionality to change) - [x] Documentation update **Infrastructure & Configuration:** - [ ] GitHub Actions workflow - [ ] Linting configuration (markdown, PowerShell, etc.) - [ ] Security configuration - [ ] DevContainer configuration - [ ] Dependency update **AI Artifacts:** - [ ] Reviewed contribution with `prompt-builder` agent and addressed all feedback - [ ] Copilot instructions (`.github/instructions/*.instructions.md`) - [ ] Copilot prompt (`.github/prompts/*.prompt.md`) - [ ] Copilot agent (`.github/agents/*.agent.md`) - [ ] Copilot skill (`.github/skills/*/SKILL.md`) > **Note for AI Artifact Contributors**: > > * **Agents**: Research, indexing/referencing other project (using standard VS Code GitHub Copilot/MCP tools), planning, and general implementation agents likely already exist. Review `.github/agents/` before creating new ones. > * **Skills**: Must include both bash and PowerShell scripts. See [Skills](../docs/contributing/skills.md). > * **Model Versions**: Only contributions targeting the **latest Anthropic and OpenAI models** will be accepted. Older model versions (e.g., GPT-3.5, Claude 3) will be rejected. > * See [Agents Not Accepted](../docs/contributing/custom-agents.md#agents-not-accepted) and [Model Version Requirements](../docs/contributing/ai-artifacts-common.md#model-version-requirements). **Other:** - [ ] Script/automation (`.ps1`, `.sh`, `.py`) - [ ] Other (please describe): ## Sample Prompts (for AI Artifact Contributions) <!-- If you checked any boxes under "AI Artifacts" above, provide a sample prompt showing how to use your contribution --> <!-- Delete this section if not applicable --> **User Request:** <!-- What natural language request would trigger this agent/prompt/instruction? --> **Execution Flow:** <!-- Step-by-step: what happens when invoked? Include tool usage, decision points --> **Output Artifacts:** <!-- What files/content are created? Show first 10-20 lines as preview --> **Success Indicators:** <!-- How does user know it worked correctly? What validation should they perform? --> For detailed contribution requirements, see: * **Common Standards**: [docs/contributing/ai-artifacts-common.md](../docs/contributing/ai-artifacts-common.md) - Shared standards for XML blocks, markdown quality, RFC 2119, validation, and testing * **Agents**: [docs/contributing/custom-agents.md](../docs/contributing/custom-agents.md) - Agent configurations with tools and behavior patterns * **Prompts**: [docs/contributing/prompts.md](../docs/contributing/prompts.md) - Workflow-specific guidance with template variables * **Instructions**: [docs/contributing/instructions.md](../docs/contributing/instructions.md) - Technology-specific standards with glob patterns * **Skills**: [docs/contributing/skills.md](../docs/contributing/skills.md) - Task execution utilities with cross-platform scripts ## Testing Automated validation performed during PR generation: - **Markdown linting** (`npm run lint:md`): Passed (0 errors, 283 files) - **Spell checking** (`npm run spell-check`): Passed (0 issues, 198 files) - **Frontmatter validation** (`npm run lint:frontmatter`): Passed (0 errors, 0 warnings) - **Skill structure validation** (`npm run validate:skills`): Passed (2 skills, 0 errors) - **Link validation** (`npm run lint:md-links`): Passed - **PowerShell analysis** (`npm run lint:ps`): Passed (all files clean) - **Plugin freshness** (`npm run plugin:generate`): Passed (idempotent, no diff) Security analysis found no sensitive data exposure, dependency vulnerabilities, or privilege modifications. Conventional commits compliance verified. No unintended file changes detected. Manual testing was not performed. ## Checklist ### Required Checks - [x] Documentation is updated (if applicable) - [x] Files follow existing naming conventions - [x] Changes are backwards compatible (if applicable) - [ ] Tests added for new functionality (if applicable) (N/A — no new testable functionality) ### AI Artifact Contributions <!-- If contributing an agent, prompt, instruction, or skill, complete these checks --> - [ ] Used `/prompt-analyze` to review contribution - [ ] Addressed all feedback from `prompt-builder` review - [ ] Verified contribution follows common standards and type-specific requirements ### Required Automated Checks The following validation commands must pass before merging: - [x] Markdown linting: `npm run lint:md` - [x] Spell checking: `npm run spell-check` - [x] Frontmatter validation: `npm run lint:frontmatter` - [x] Skill structure validation: `npm run validate:skills` - [x] Link validation: `npm run lint:md-links` - [x] PowerShell analysis: `npm run lint:ps` - [x] Plugin freshness: `npm run plugin:generate` ## Security Considerations <!--⚠️ WARNING: Do not commit sensitive information such as API keys, passwords, or personal data --> - [x] This PR does not contain any sensitive or NDA information - [ ] Any new dependencies have been reviewed for security issues (N/A — no dependency changes) - [ ] Security-related scripts follow the principle of least privilege (N/A — no security script changes) ## Additional Notes All 14 changed files were verified: 4 source files modified, 7 symlinks added, 3 plugin READMEs regenerated. Plugin output freshness was confirmed via idempotent `npm run plugin:generate` re-run during implementation. Co-authored-by: Bill Berry <wbery@microsoft.com>
This was referenced Feb 27, 2026
WilliamBerryiii
pushed a commit
that referenced
this pull request
Feb 28, 2026
## Pre-Release 3.1.44 ### ✨ Features - add Docusaurus 3 documentation site with GitHub Pages deployment (#680) - add workflow permissions validation for OpenSSF Scorecard compliance (#759) - add DT coach return path handoff to task-researcher (#591) (#758) - add DT subagent handoff workflow instructions (#592) (#757) - create dt-method-06-deep.instructions.md (#602) (#748) - create dt-method-05-deep.instructions.md (#747) - add DT-aware task-implementor context instructions (#755) - extract embedded PowerShell from workflows into testable scripts (#738) - add gitleaks binary-based secret scanning as PR gate (#734) - add SBOM generation, attestation, and diff tooling to release pipeline (#730) - add dt-learning-tutor agent for DT education (#662) - add DT image prompt generation guidance for Method 5 (#726) - add DT-aware task-reviewer review context (#714) - add dt-method-next routing prompt (#713) - create dt-method-04-deep.instructions.md (#709) - add Implementation Space exit handoff prompt for DT workflows (#708) - add Write-CIStepSummary markdown table to Test-SHAStaleness github output (#660) - add dt-handoff-solution-space prompt for Solution Spac… (#707) ### 🐛 Bug Fixes - update sidebar link color to meet WCAG AA contrast requirements (#814) - harden even/odd versioning against regression and syntax errors (#816) - replace even/odd versioning with SemVer -rc.N suffixes (#811) - ensure prerelease label exists before PR creation (#806) - replace Docusaurus favicons with Microsoft logo (#808) - add missing subagents and shared instructions to collection manifests (#804) - standardize file path conventions for copilot-tracking output (#784) - enforce project-scoped artifact isolation across DT files (#766) - add top-level permissions to copilot-setup-steps.yml (#760) - update broken file directives and markdown links after collection directory reorg (#743) - add pre-release companion pipeline with even/odd versioning (#735) - exclude auto-generated CHANGELOG.md from spell check (#756) - add job-level permissions to extension-publish.yml (#729) - resolve handoff dependencies using display names (#727) - add job-level permissions to validate-version in extension-publish-prerelease (#731) - replace parent-directory VS Code settings paths with per-subdirectory enumeration (#732) ### 📚 Documentation - add Design Thinking documentation and DT-to-RPI handoff (#789) - add customization guides for HVE Core artifacts (#772) - reconcile documentation against implementation (#771) - document accepted Token-Permissions risks and add lint:dependency-pinning (#763) - add Design Thinking section to hve-core-all collection description (#762) ### ♻️ Refactoring - move collection scripts from plugins to collections (#728) - remove duplicate git diff logic in frontmatter validator (#473) ### 🔧 Maintenance - bump basic-ftp from 5.0.5 to 5.2.0 (#780) - standardize script path references in SKILL.md files (#768) - bump the github-actions group across 1 directory with 2 updates (#752) --- *Managed automatically by pre-release workflow.* Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
WilliamBerryiii
pushed a commit
that referenced
this pull request
Feb 28, 2026
## Pre-Release 3.1.46 ### ✨ Features - add Docusaurus 3 documentation site with GitHub Pages deployment (#680) - add workflow permissions validation for OpenSSF Scorecard compliance (#759) - add DT coach return path handoff to task-researcher (#591) (#758) - add DT subagent handoff workflow instructions (#592) (#757) - create dt-method-06-deep.instructions.md (#602) (#748) - create dt-method-05-deep.instructions.md (#747) - add DT-aware task-implementor context instructions (#755) - extract embedded PowerShell from workflows into testable scripts (#738) - add gitleaks binary-based secret scanning as PR gate (#734) - add SBOM generation, attestation, and diff tooling to release pipeline (#730) - add dt-learning-tutor agent for DT education (#662) - add DT image prompt generation guidance for Method 5 (#726) - add DT-aware task-reviewer review context (#714) - add dt-method-next routing prompt (#713) - create dt-method-04-deep.instructions.md (#709) - add Implementation Space exit handoff prompt for DT workflows (#708) - add Write-CIStepSummary markdown table to Test-SHAStaleness github output (#660) - add dt-handoff-solution-space prompt for Solution Spac… (#707) ### 🐛 Bug Fixes - update prerelease publish to use even/odd convention (#822) - update sidebar link color to meet WCAG AA contrast requirements (#814) - harden even/odd versioning against regression and syntax errors (#816) - replace even/odd versioning with SemVer -rc.N suffixes (#811) - ensure prerelease label exists before PR creation (#806) - replace Docusaurus favicons with Microsoft logo (#808) - add missing subagents and shared instructions to collection manifests (#804) - standardize file path conventions for copilot-tracking output (#784) - enforce project-scoped artifact isolation across DT files (#766) - add top-level permissions to copilot-setup-steps.yml (#760) - update broken file directives and markdown links after collection directory reorg (#743) - add pre-release companion pipeline with even/odd versioning (#735) - exclude auto-generated CHANGELOG.md from spell check (#756) - add job-level permissions to extension-publish.yml (#729) - resolve handoff dependencies using display names (#727) - add job-level permissions to validate-version in extension-publish-prerelease (#731) - replace parent-directory VS Code settings paths with per-subdirectory enumeration (#732) ### 📚 Documentation - add Design Thinking documentation and DT-to-RPI handoff (#789) - add customization guides for HVE Core artifacts (#772) - reconcile documentation against implementation (#771) - document accepted Token-Permissions risks and add lint:dependency-pinning (#763) - add Design Thinking section to hve-core-all collection description (#762) ### ♻️ Refactoring - move collection scripts from plugins to collections (#728) - remove duplicate git diff logic in frontmatter validator (#473) ### 🔧 Maintenance - pre-release 3.1.44 (#819) - bump basic-ftp from 5.0.5 to 5.2.0 (#780) - standardize script path references in SKILL.md files (#768) - bump the github-actions group across 1 directory with 2 updates (#752) --- *Managed automatically by pre-release workflow.* Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collection manifests had gaps where parent agents declared subagent dependencies that were not listed in the corresponding
collections/*.collection.ymlfiles. The project-planning collection was missing five RPI subagent entries, the design-thinking and experimental collections were missing the shared hve-core-location instruction, and the project-planning.collection.md description was incomplete. This PR closed all identified gaps and regenerated affected plugin outputs.Description
Collection YAML Manifest Completeness
Five
kind: agententries were added to project-planning.collection.yml for researcher-subagent, plan-validator, phase-implementor, rpi-validator, and implementation-validator, all referencing canonical files in.github/agents/hve-core/subagents/. Akind: instructionentry for hve-core-location.instructions.md was added to both design-thinking.collection.yml and experimental.collection.yml.Collection Markdown Description
project-planning.collection.md was expanded with four previously missing agent descriptions (Product Manager Advisor, UX/UI Designer, System Architecture Reviewer, and RPI Agent) and a new "Supporting subagents included" section with five subagent descriptions. Entries were reordered for logical grouping, and all bullets were normalized to the
- **Name** —convention matching other collection markdown files.Plugin Output Regeneration
All affected plugin outputs were regenerated via
npm run plugin:generate. Three README files gained new table rows (plugins/design-thinking/README.md, plugins/experimental/README.md, plugins/project-planning/README.md), and seven new symlinks were created underplugins/directories pointing to canonical source files.Related Issue(s)
Fixes #802
Type of Change
Select all that apply:
Code & Documentation:
Infrastructure & Configuration:
AI Artifacts:
prompt-builderagent and addressed all feedback.github/instructions/*.instructions.md).github/prompts/*.prompt.md).github/agents/*.agent.md).github/skills/*/SKILL.md)Other:
.ps1,.sh,.py)Sample Prompts (for AI Artifact Contributions)
User Request:
Execution Flow:
Output Artifacts:
Success Indicators:
For detailed contribution requirements, see:
Testing
Automated validation performed during PR generation:
npm run lint:md): Passed (0 errors, 283 files)npm run spell-check): Passed (0 issues, 198 files)npm run lint:frontmatter): Passed (0 errors, 0 warnings)npm run validate:skills): Passed (2 skills, 0 errors)npm run lint:md-links): Passednpm run lint:ps): Passed (all files clean)npm run plugin:generate): Passed (idempotent, no diff)Security analysis found no sensitive data exposure, dependency vulnerabilities, or privilege modifications. Conventional commits compliance verified. No unintended file changes detected.
Manual testing was not performed.
Checklist
Required Checks
AI Artifact Contributions
/prompt-analyzeto review contributionprompt-builderreviewRequired Automated Checks
The following validation commands must pass before merging:
npm run lint:mdnpm run spell-checknpm run lint:frontmatternpm run validate:skillsnpm run lint:md-linksnpm run lint:psnpm run plugin:generateSecurity Considerations
Additional Notes
All 14 changed files were verified: 4 source files modified, 7 symlinks added, 3 plugin READMEs regenerated. Plugin output freshness was confirmed via idempotent
npm run plugin:generatere-run during implementation.