Skip to content

[Shared-Everything] ArrayRMW and ArrayCmpxchg #7632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Jun 2, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
yolo
  • Loading branch information
kripken committed May 29, 2025
commit e23e19663e8529c83d529c4db4fc29239cd139f7
2 changes: 2 additions & 0 deletions src/ir/ReFinalize.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,8 @@ void ReFinalize::visitArrayCopy(ArrayCopy* curr) { curr->finalize(); }
void ReFinalize::visitArrayFill(ArrayFill* curr) { curr->finalize(); }
void ReFinalize::visitArrayInitData(ArrayInitData* curr) { curr->finalize(); }
void ReFinalize::visitArrayInitElem(ArrayInitElem* curr) { curr->finalize(); }
void ReFinalize::visitArrayRMW(ArrayRMW* curr) { curr->finalize(); }
void ReFinalize::visitArrayCmpxchg(ArrayCmpxchg* curr) { curr->finalize(); }
void ReFinalize::visitRefAs(RefAs* curr) { curr->finalize(); }
void ReFinalize::visitStringNew(StringNew* curr) { curr->finalize(); }
void ReFinalize::visitStringConst(StringConst* curr) { curr->finalize(); }
Expand Down
20 changes: 20 additions & 0 deletions src/ir/possible-contents.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1100,6 +1100,22 @@ struct InfoCollector
}
void visitArrayInitData(ArrayInitData* curr) { visitArrayInit(curr); }
void visitArrayInitElem(ArrayInitElem* curr) { visitArrayInit(curr); }
void visitArrayRMW(ArrayRMW* curr) {
if (curr->ref->type == Type::unreachable) {
return;
}
// TODO: Model the modification part of the RMW in addition to the read and
// the write.
addRoot(curr);
}
void visitArrayCmpxchg(ArrayCmpxchg* curr) {
if (curr->ref->type == Type::unreachable) {
return;
}
// TODO: Model the modification part of the RMW in addition to the read and
// the write.
addRoot(curr);
}
void visitStringNew(StringNew* curr) {
if (curr->type == Type::unreachable) {
return;
Expand Down Expand Up @@ -1618,6 +1634,10 @@ void TNHOracle::scan(Function* func,
void visitArrayInitElem(ArrayInitElem* curr) {
notePossibleTrap(curr->ref);
}
void visitArrayRMW(ArrayRMW* curr) { notePossibleTrap(curr->ref); }
void visitArrayCmpxchg(ArrayCmpxchg* curr) {
notePossibleTrap(curr->ref);
}

void visitFunction(Function* curr) {
// In optimized TNH code, a function that always traps will be turned
Expand Down
12 changes: 12 additions & 0 deletions src/passes/Heap2Local.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,18 @@ struct EscapeAnalyzer {
escapes = false;
fullyConsumes = true;
}
void visitArrayRMW(ArrayRMW* curr) {
if (curr->ref == child) {
escapes = false;
fullyConsumes = true;
}
}
void visitArrayCmpxchg(ArrayCmpxchg* curr) {
if (curr->ref == child || curr->expected == child) {
escapes = false;
fullyConsumes = true;
}
}
// TODO other GC operations
} checker;

Expand Down
4 changes: 4 additions & 0 deletions src/passes/TypeGeneralizing.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -727,6 +727,10 @@ struct TransferFn : OverriddenVisitor<TransferFn> {
}
}

void visitArrayRMW(ArrayRMW* curr) { WASM_UNREACHABLE("TODO"); }

void visitArrayCmpxchg(ArrayCmpxchg* curr) { WASM_UNREACHABLE("TODO"); }

HeapType
generalizeArrayType(HeapType type,
std::optional<Type> reqFieldType = std::nullopt) {
Expand Down