Skip to content

[Shared-Everything] ArrayRMW and ArrayCmpxchg #7632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Jun 2, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
work
  • Loading branch information
kripken committed May 29, 2025
commit 20516a794525f0f4d203fc4628c5879c3009fb01
6 changes: 3 additions & 3 deletions src/ir/child-typer.h
Original file line number Diff line number Diff line change
Expand Up @@ -1136,7 +1136,7 @@ template<typename Subtype> struct ChildTyper : OverriddenVisitor<Subtype> {
}
auto type = ht->getArray().element.type;
note(&curr->ref, Type(*ht, Nullable));
note(&curr->value, type.type);
note(&curr->value, type);
}

void visitArrayCmpxchg(ArrayCmpxchg* curr,
Expand All @@ -1149,8 +1149,8 @@ template<typename Subtype> struct ChildTyper : OverriddenVisitor<Subtype> {
}
auto type = ht->getArray().element.type;
note(&curr->ref, Type(*ht, Nullable));
note(&curr->expected, type.type);
note(&curr->replacement, type.type);
note(&curr->expected, type);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be eqref if type is a reference and type otherwise. I see this is wrong for StructCmpxchg as well.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed both.

note(&curr->replacement, type);
}

void visitRefAs(RefAs* curr) {
Expand Down