Skip to content

[Shared-Everything] ArrayRMW and ArrayCmpxchg #7632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Jun 2, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix ChildTyper expected fields
  • Loading branch information
kripken committed Jun 2, 2025
commit af6dea2a76080015c1fbe6b62015edeacfe7de9d
4 changes: 2 additions & 2 deletions src/ir/child-typer.h
Original file line number Diff line number Diff line change
Expand Up @@ -997,7 +997,7 @@ template<typename Subtype> struct ChildTyper : OverriddenVisitor<Subtype> {
const auto& fields = ht->getStruct().fields;
assert(curr->index < fields.size());
note(&curr->ref, Type(*ht, Nullable));
note(&curr->expected, fields[curr->index].type);
note(&curr->expected, Type(HeapType::eq, Nullable));
note(&curr->replacement, fields[curr->index].type);
}

Expand Down Expand Up @@ -1151,7 +1151,7 @@ template<typename Subtype> struct ChildTyper : OverriddenVisitor<Subtype> {
auto type = ht->getArray().element.type;
note(&curr->ref, Type(*ht, Nullable));
note(&curr->index, Type::i32);
note(&curr->expected, type);
note(&curr->expected, Type(HeapType::eq, Nullable));
note(&curr->replacement, type);
}

Expand Down