Skip to content

[Shared-Everything] ArrayRMW and ArrayCmpxchg #7632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Jun 2, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
work
  • Loading branch information
kripken committed May 29, 2025
commit 4f3defa6ee175a047d072ea30e6cb0e75e4fbaf2
12 changes: 6 additions & 6 deletions scripts/gen-s-parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -654,12 +654,12 @@
("array.init_data", "makeArrayInitData()"),
("array.init_elem", "makeArrayInitElem()"),
("array.atomic.rmw.add", "makeArrayRMW(RMWAdd)"),
("array.atomic.rmw.sub", "makemakeArrayRMW(RMWSub)"),
("array.atomic.rmw.and", "makemakeArrayRMW(RMWAnd)"),
("array.atomic.rmw.or", "makemakeArrayRMW(RMWOr)"),
("array.atomic.rmw.xor", "makemakeArrayRMW(RMWXor)"),
("array.atomic.rmw.xchg", "makemakeArrayRMW(RMWXchg)"),
("array.atomic.rmw.cmpxchg", "makemakeArrayCmpxchg()"),
("array.atomic.rmw.sub", "makeArrayRMW(RMWSub)"),
("array.atomic.rmw.and", "makeArrayRMW(RMWAnd)"),
("array.atomic.rmw.or", "makeArrayRMW(RMWOr)"),
("array.atomic.rmw.xor", "makeArrayRMW(RMWXor)"),
("array.atomic.rmw.xchg", "makeArrayRMW(RMWXchg)"),
("array.atomic.rmw.cmpxchg", "makeArrayCmpxchg()"),
("ref.as_non_null", "makeRefAs(RefAsNonNull)"),
("extern.internalize", "makeRefAs(AnyConvertExtern)"), # Deprecated
("extern.externalize", "makeRefAs(ExternConvertAny)"), # Deprecated
Expand Down
12 changes: 6 additions & 6 deletions src/gen-s-parser.inc
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ switch (buf[0]) {
goto parse_error;
case 'n':
if (op == "array.atomic.rmw.and"sv) {
CHECK_ERR(makemakeArrayRMW(ctx, pos, annotations, RMWAnd));
CHECK_ERR(makeArrayRMW(ctx, pos, annotations, RMWAnd));
return Ok{};
}
goto parse_error;
Expand All @@ -73,33 +73,33 @@ switch (buf[0]) {
}
case 'c':
if (op == "array.atomic.rmw.cmpxchg"sv) {
CHECK_ERR(makemakeArrayCmpxchg(ctx, pos, annotations));
CHECK_ERR(makeArrayCmpxchg(ctx, pos, annotations));
return Ok{};
}
goto parse_error;
case 'o':
if (op == "array.atomic.rmw.or"sv) {
CHECK_ERR(makemakeArrayRMW(ctx, pos, annotations, RMWOr));
CHECK_ERR(makeArrayRMW(ctx, pos, annotations, RMWOr));
return Ok{};
}
goto parse_error;
case 's':
if (op == "array.atomic.rmw.sub"sv) {
CHECK_ERR(makemakeArrayRMW(ctx, pos, annotations, RMWSub));
CHECK_ERR(makeArrayRMW(ctx, pos, annotations, RMWSub));
return Ok{};
}
goto parse_error;
case 'x': {
switch (buf[18]) {
case 'c':
if (op == "array.atomic.rmw.xchg"sv) {
CHECK_ERR(makemakeArrayRMW(ctx, pos, annotations, RMWXchg));
CHECK_ERR(makeArrayRMW(ctx, pos, annotations, RMWXchg));
return Ok{};
}
goto parse_error;
case 'o':
if (op == "array.atomic.rmw.xor"sv) {
CHECK_ERR(makemakeArrayRMW(ctx, pos, annotations, RMWXor));
CHECK_ERR(makeArrayRMW(ctx, pos, annotations, RMWXor));
return Ok{};
}
goto parse_error;
Expand Down