Jazzy Sync 7: May 29 2025 #5211
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* redesign dynamic param patterns Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> * change cache version Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> * check that parameter of type double are >=0.0 Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> --------- Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com>
…ction (#4925) * Add force_use_current_pose Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * xml update Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * rename to use_start Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * lint Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * descriptions Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * simplify logic Signed-off-by: Guillaume Doisy <guillaume@dexory.com> --------- Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com>
… string (#4926) * [CostmapTopicCollisionChecker] Alternative constructor with footprint Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * raw pointer Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * suggestions from review Signed-off-by: Guillaume Doisy <guillaume@dexory.com> --------- Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com>
* merged changes from humble for goal.header fix * reverted back, error in merge * ported goal.header fix in navfn_planner.cpp from humble * reverted to navfn_planner.cpp to origin/main * merged navfn_planner.cpp from humble * fixed the merge
* Update map_io library to use opencv method for faster map loading Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Update pre-commit config changes Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Use Eigen approach instead of OpenCV Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Update pre-commit changes Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Update include header include order Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Remove intermediary alpha matrix Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Add comments for the code understanding Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Fix else braces rule issue Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Create and use alpha_matrix when applying mask Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Update pre-commit changes Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Take flip part out of if-else Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Update pre-commit changes Signed-off-by: Vignesh T <vignesh.t@kabam.ai> --------- Signed-off-by: Vignesh T <vignesh.t@kabam.ai>
Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
…uttons (#5137) Signed-off-by: Pradheep <padhupradheep@gmail.com>
…5148) * Warn if inflation radius is smaller than circumscribed radius Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * Update nav2_mppi_controller/src/critics/cost_critic.cpp Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Tony Najjar <t03578624@gmail.com> * Update nav2_smac_planner/include/nav2_smac_planner/utils.hpp Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Tony Najjar <t03578624@gmail.com> --------- Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> Signed-off-by: Tony Najjar <t03578624@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
…on. (#5165) Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
* Adding declare_or_get_param util to node utils Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> * Adding test for declare_or_get_param util Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> * Adding declare_or_get_parameter function by type, using explicit variable names, disabling param warnings by default Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> * Update nav2_util/test/test_node_utils.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Fixing codecove test Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> * Catching possible exception in declare_or_get_by_type Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> * Templating return type of declare parameter by value Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> --------- Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
* added config for laserscan in lb-sim Signed-off-by: RamanaBotta <ramanab@bosonmotors.com> * fixing ament_flake8 errors Signed-off-by: RamanaBotta <ramanab@bosonmotors.com> * review: use_inf is default:true and added parameters on readme #4992 Signed-off-by: RamanaBotta <ramanab@bosonmotors.com> * refactor: meaningfull value for scan_angle_increment Signed-off-by: RamanaBotta <ramanab@bosonmotors.com> --------- Signed-off-by: RamanaBotta <ramanab@bosonmotors.com> Co-authored-by: RamanaBotta <ramanab@bosonmotors.com>
* Publish planned footprints after smoothing Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * Revert "Publish planned footprints after smoothing" This reverts commit c9b349a. * Add smoothed footprints publishing Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * fix formatting Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * Fix indentation for publisher creation in SmacPlannerHybrid and SmacPlannerLattice Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * address PR comments Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * fixes Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * fix build error Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> --------- Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
* Adding missing dep Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * typo Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * updating fix Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
…arameter warnings (#5189) * Adding a parameter warn_when_defaulting_parameters to control default parameter warnings instead of using a flag Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> * Adding parameter strict_param_loading for optionally throwing an exception if parameter overrides are missing Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> * Using default false declaration instead of declare_or_get in param util Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> --------- Signed-off-by: Marco Bassa <marco.bassa@idealworks.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
RBT22
pushed a commit
to EnjoyRobotics/navigation2
that referenced
this pull request
Sep 11, 2025
* Dynamic param patterns (ros-navigation#4971) * redesign dynamic param patterns Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> * change cache version Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> * check that parameter of type double are >=0.0 Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> --------- Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> * [nav2_behavior_tree] Add force_use_current_pose to ComputePathToPoseAction (ros-navigation#4925) * Add force_use_current_pose Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * xml update Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * rename to use_start Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * lint Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * descriptions Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * simplify logic Signed-off-by: Guillaume Doisy <guillaume@dexory.com> --------- Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com> * [CostmapTopicCollisionChecker] Alternative constructor with footprint string (ros-navigation#4926) * [CostmapTopicCollisionChecker] Alternative constructor with footprint Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * raw pointer Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * suggestions from review Signed-off-by: Guillaume Doisy <guillaume@dexory.com> --------- Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com> * Merged Fix navfn_planner from humble PR ros-navigation#5087 (ros-navigation#5092) * merged changes from humble for goal.header fix * reverted back, error in merge * ported goal.header fix in navfn_planner.cpp from humble * reverted to navfn_planner.cpp to origin/main * merged navfn_planner.cpp from humble * fixed the merge * Update map_io library to use Eigen method for faster map loading (ros-navigation#5071) * Update map_io library to use opencv method for faster map loading Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Update pre-commit config changes Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Use Eigen approach instead of OpenCV Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Update pre-commit changes Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Update include header include order Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Remove intermediary alpha matrix Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Add comments for the code understanding Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Fix else braces rule issue Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Create and use alpha_matrix when applying mask Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Update pre-commit changes Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Take flip part out of if-else Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Update pre-commit changes Signed-off-by: Vignesh T <vignesh.t@kabam.ai> --------- Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Precompute yaw trigonometric values in smac planner (ros-navigation#5109) Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * removing the start navigation message in the paused state from rviz buttons (ros-navigation#5137) Signed-off-by: Pradheep <padhupradheep@gmail.com> * Show error if inflation radius is smaller than circumscribed radius (ros-navigation#5148) * Warn if inflation radius is smaller than circumscribed radius Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * Update nav2_mppi_controller/src/critics/cost_critic.cpp Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Tony Najjar <t03578624@gmail.com> * Update nav2_smac_planner/include/nav2_smac_planner/utils.hpp Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Tony Najjar <t03578624@gmail.com> --------- Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> Signed-off-by: Tony Najjar <t03578624@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> * Prevent MPPI controller from resetting speed limits upon goal execution. (ros-navigation#5165) Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Fixing docking server when already docked at the requeste ddock (ros-navigation#5171) Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Adding parameter util to node utils (ros-navigation#5154) * Adding declare_or_get_param util to node utils Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> * Adding test for declare_or_get_param util Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> * Adding declare_or_get_parameter function by type, using explicit variable names, disabling param warnings by default Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> * Update nav2_util/test/test_node_utils.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Fixing codecove test Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> * Catching possible exception in declare_or_get_by_type Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> * Templating return type of declare parameter by value Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> --------- Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> * added config for laserscan in lb-sim (ros-navigation#5174) * added config for laserscan in lb-sim Signed-off-by: RamanaBotta <ramanab@bosonmotors.com> * fixing ament_flake8 errors Signed-off-by: RamanaBotta <ramanab@bosonmotors.com> * review: use_inf is default:true and added parameters on readme ros-navigation#4992 Signed-off-by: RamanaBotta <ramanab@bosonmotors.com> * refactor: meaningfull value for scan_angle_increment Signed-off-by: RamanaBotta <ramanab@bosonmotors.com> --------- Signed-off-by: RamanaBotta <ramanab@bosonmotors.com> Co-authored-by: RamanaBotta <ramanab@bosonmotors.com> * Publish planned footprints after smoothing (ros-navigation#5155) * Publish planned footprints after smoothing Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * Revert "Publish planned footprints after smoothing" This reverts commit c9b349a. * Add smoothed footprints publishing Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * fix formatting Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * Fix indentation for publisher creation in SmacPlannerHybrid and SmacPlannerLattice Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * address PR comments Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * fixes Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * fix build error Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> --------- Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * fixing deprecation warning (ros-navigation#5182) Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Adding missing dep to loopback sim (ros-navigation#5204) * Adding missing dep Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * typo Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * updating fix Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Adding parameter warn_when_defaulting_parameters to control default parameter warnings (ros-navigation#5189) * Adding a parameter warn_when_defaulting_parameters to control default parameter warnings instead of using a flag Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> * Adding parameter strict_param_loading for optionally throwing an exception if parameter overrides are missing Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> * Using default false declaration instead of declare_or_get in param util Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> --------- Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> * bumping to 1.3.7 for release Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Signed-off-by: Vignesh T <vignesh.t@kabam.ai> Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Signed-off-by: Pradheep <padhupradheep@gmail.com> Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> Signed-off-by: Tony Najjar <t03578624@gmail.com> Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> Signed-off-by: RamanaBotta <ramanab@bosonmotors.com> Co-authored-by: Nils-Christian Iseke <48475933+Nils-ChristianIseke@users.noreply.github.com> Co-authored-by: Guillaume Doisy <doisyg@users.noreply.github.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Sandeep Dutta <quark01@gmail.com> Co-authored-by: Vignesh T <vignesh.t@kabam.ai> Co-authored-by: mini-1235 <mauricepurnawan@gmail.com> Co-authored-by: Pradheep Krishna <padhupradheep@gmail.com> Co-authored-by: Tony Najjar <tony.najjar.1997@gmail.com> Co-authored-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> Co-authored-by: Marco Bassa <101661130+MarcoMatteoBassa@users.noreply.github.com> Co-authored-by: Raman <52356167+RamanRobotics@users.noreply.github.com> Co-authored-by: RamanaBotta <ramanab@bosonmotors.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.