Skip to content

wait for scene load before default camera check (fixes #1723) #1724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2016
Merged

wait for scene load before default camera check (fixes #1723) #1724

merged 1 commit into from
Aug 5, 2016

Conversation

@ngokevin
Copy link
Member

@ngokevin ngokevin commented Aug 4, 2016

Description:

Found an issue where scene was using default camera despite having a defined one, in the case where the scene has assets.

Caught this in one of my scenes when I had a camera + cursor that wasn't being used, so I saw that the cursor was just hanging in space in a separate camera.

Changes proposed:

  • Wait for scene load before camera check.
  • Remove nodeready and isNode check in addToParent now that I fixed our document.registerElement.
@dmarcos dmarcos merged commit 679a5d9 into aframevr:master Aug 5, 2016
This was referenced Aug 10, 2016
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs review

2 participants

@ngokevin @dmarcos