wait for camera to be active before rendering (fixes #1733, fixes #1754) #1756
Conversation
|
|
||
| this.addEventListener('loaded', function () { | ||
| if (this.renderStarted) { return; } | ||
| AEntity.prototype.play.call(this); // .play() *before* render. |
There was a problem hiding this comment.
Are you sure you want to start playing before rendering? What if there's components that rely on having an active camera?
There was a problem hiding this comment.
All entities initialize before the scene gets here. With our without this patch, I believe they would have had to listen to the camera-set-active event, so nothing is changed here.
I had it within the startRender before but it broke some tests. I can try to play with it more.
There was a problem hiding this comment.
But yeah, perhaps it's best to start execution and rendering at the same time.
There was a problem hiding this comment.
I tried to get it working by calling play only after camera, but couldn't get the tests passing. I might have some code quality improvements though.
2 participants
Description:
Caused by #1724
Since we waited for scene to load before setting up the camera. We have to tell the scene to wait for the camera as well.
Changes proposed:
camera-set-activebefore render if camera does not yet exist.