-
Notifications
You must be signed in to change notification settings - Fork 35
[ci] update versions of ES, GitHub Actions #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| steps: | ||
| - name: checkout repository | ||
| uses: actions/checkout@v2.3.4 | ||
| uses: actions/checkout@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/actions/checkout uses v2 the way some projects use a stable tag. For example, if they publish a 2.3.5, at that moment v2.3.5 and v2 will point to the same commit.
So this is equivalent to doing something like >=2.0.0,<3.0.0 in Python
|
R jobs are failing with the following According to https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-README.md, |
.ci/setup.sh
Outdated
| Rscript -e "install.packages(c('assertthat', 'covr', 'data.table', 'futile.logger', 'httr', 'jsonlite', 'knitr', 'lintr', 'purrr', 'rmarkdown', 'stringr', 'testthat', 'uuid'), repos = 'https://cran.r-project.org')" | ||
| conda install -y -c conda-forge 'pandoc>1.12.3' | ||
|
|
||
| Rscript -e "install.packages(c('assertthat', 'covr', 'data.table', 'futile.logger', 'httr', 'jsonlite', 'knitr', 'lintr', 'purrr', 'rmarkdown', 'stringr', 'testthat', 'uuid'), repos = 'https://cran.r-project.org'), Ncpus = parallel::detectCores())" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
installing packages is taking 8+ minutes (!!!), so I'm taking the opportunity to also add Ncpus = parallel::detectCores() here in install.packages().
Codecov Report
@@ Coverage Diff @@
## master #220 +/- ##
=======================================
Coverage 95.47% 95.47%
=======================================
Files 8 8
Lines 597 597
=======================================
Hits 570 570
Misses 27 27 Continue to review full report at Codecov.
|
It's been about 7 months since the last commit in this project (#217). This PR updates a few versions of things in CI as standard maintenance.