Skip to content

Conversation

@jameslamb
Copy link
Collaborator

It's been about 7 months since the last commit in this project (#217). This PR updates a few versions of things in CI as standard maintenance.

steps:
- name: checkout repository
uses: actions/checkout@v2.3.4
uses: actions/checkout@v2
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/actions/checkout uses v2 the way some projects use a stable tag. For example, if they publish a 2.3.5, at that moment v2.3.5 and v2 will point to the same commit.

So this is equivalent to doing something like >=2.0.0,<3.0.0 in Python

@austin3dickey austin3dickey self-requested a review May 24, 2021 19:47
@jameslamb jameslamb marked this pull request as ready for review May 25, 2021 02:17
@jameslamb
Copy link
Collaborator Author

R jobs are failing with the following

Error: --- re-building ‘FAQ.Rmd’ using rmarkdown
Warning in engine$weave(file, quiet = quiet, encoding = enc) :
  Pandoc (>= 1.12.3) not available. Falling back to R Markdown v1.
Error: Error: processing vignette 'FAQ.Rmd' failed with diagnostics:
The 'markdown' package should be installed and declared as a dependency of the 'uptasticsearch' package (e.g., in the 'Suggests' field of DESCRIPTION), because the latter contains vignette(s) built with the 'markdown' package. Please see https://github.com/yihui/knitr/issues/1864 for more information.
--- failed re-building ‘FAQ.Rmd’

SUMMARY: processing the following file failed:
  ‘FAQ.Rmd’

Error: Error: Vignette re-building failed.
Execution halted
Error: Process completed with exit code 1.

According to https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-README.md, pandoc isn't guaranteed to be available. I'll add it here.

.ci/setup.sh Outdated
Rscript -e "install.packages(c('assertthat', 'covr', 'data.table', 'futile.logger', 'httr', 'jsonlite', 'knitr', 'lintr', 'purrr', 'rmarkdown', 'stringr', 'testthat', 'uuid'), repos = 'https://cran.r-project.org')"
conda install -y -c conda-forge 'pandoc>1.12.3'

Rscript -e "install.packages(c('assertthat', 'covr', 'data.table', 'futile.logger', 'httr', 'jsonlite', 'knitr', 'lintr', 'purrr', 'rmarkdown', 'stringr', 'testthat', 'uuid'), repos = 'https://cran.r-project.org'), Ncpus = parallel::detectCores())"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

installing packages is taking 8+ minutes (!!!), so I'm taking the opportunity to also add Ncpus = parallel::detectCores() here in install.packages().

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2021

Codecov Report

Merging #220 (2e4e3a3) into master (dd59ddd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #220   +/-   ##
=======================================
  Coverage   95.47%   95.47%           
=======================================
  Files           8        8           
  Lines         597      597           
=======================================
  Hits          570      570           
  Misses         27       27           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd59ddd...2e4e3a3. Read the comment docs.

@jameslamb jameslamb merged commit 2ffa100 into uptake:master May 25, 2021
@jameslamb jameslamb deleted the es-versions branch May 25, 2021 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants