Skip to content

Conversation

@jameslamb
Copy link
Collaborator

@jameslamb jameslamb commented Nov 8, 2020

This PR attempts to fix #215. See that issue and the links in it for details. Basically, Travis is becoming a lot harder for open source projects to use, and I think GitHub Actions is mature enough that we can move this project to it.

@jameslamb jameslamb removed the request for review from austin3dickey November 8, 2020 07:19
@codecov-io
Copy link

codecov-io commented Nov 8, 2020

Codecov Report

Merging #217 (0564dae) into master (8bcd886) will increase coverage by 2.34%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #217      +/-   ##
==========================================
+ Coverage   93.13%   95.47%   +2.34%     
==========================================
  Files           8        8              
  Lines         597      597              
==========================================
+ Hits          556      570      +14     
+ Misses         41       27      -14     
Impacted Files Coverage Δ
R/es_search.R 90.90% <0.00%> (+3.03%) ⬆️
R/get_fields.R 100.00% <0.00%> (+5.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bcd886...0564dae. Read the comment docs.

@jameslamb jameslamb changed the title [WIP] [ci] Move CI to GitHub Actions (fixes #215) Nov 9, 2020
include:
#---#
# R #
#---#
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cute

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, thank you

Copy link
Collaborator

@austin3dickey austin3dickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing whether the transient-failed build will block merge even if I approve

@austin3dickey
Copy link
Collaborator

Yep LGTM! Looks like you just need to rebuild because it timed out trying to pull data.table from CRAN in one of the tests. Great work!

@jameslamb
Copy link
Collaborator Author

Looks like you just need to rebuild because it timed out trying to pull data.table from CRAN in one of the tests

😬 hopefully that's just a fluke. If it becomes a real problem we could probably change the timeout or start caching those packages or something

@jameslamb
Copy link
Collaborator Author

I just changed the branch rules to require that all GitHub Actions jobs pass before a PR can be merged

image

@jameslamb jameslamb merged commit dd59ddd into master Nov 10, 2020
@jameslamb jameslamb deleted the ci/github-actions branch November 10, 2020 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants