-
Notifications
You must be signed in to change notification settings - Fork 5k
test: put unit test run first #33448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @SallyHuo-TAOS, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a minor configuration change to the CI test suite. The primary goal is to reorder the execution of tests, specifically ensuring that the '82-UnitTest' runs with a higher priority. This adjustment aims to optimize the feedback loop by identifying potential issues earlier in the continuous integration process. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to prioritize the execution of unit tests in the CI pipeline by increasing their priority value in the test/ci/cases.task file. The change from 100 to 101 achieves this for the current set of tests. However, my review includes a suggestion to use a significantly higher priority value to make this ordering more robust and prevent accidental reordering in the future, ensuring that these fast-feedback tests consistently run first as intended.
| # 82-UnitTest | ||
|
|
||
| 100,,n,cases,bash 82-UnitTest/test.sh | ||
| 101,,n,cases,bash 82-UnitTest/test.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While changing the priority from 100 to 101 correctly places the unit tests before other tests with priority 100, this approach is somewhat fragile. If another test is added in the future with a priority higher than 101, the unit tests will no longer run first, which would defeat the purpose of this change.
To make the intention clearer and more robust for the long term, consider using a significantly higher priority number. This would create a larger gap and clearly signal that these crucial, fast-feedback tests should always run first, reducing the chance of accidental reordering. For example, a priority of 200 could be used.
200,,n,cases,bash 82-UnitTest/test.sh
Description
Please briefly describe the code changes in this pull request.
Checklist
Please check the items in the checklist if applicable.