Skip to content

test: put unit test run first #33448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −1
Open

test: put unit test run first #33448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4574438
test: put unit test run first
SallyHuo-TAOS Oct 31, 2025
c3f680e
test: put unit test run first
SallyHuo-TAOS Oct 31, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/ci/cases.task
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -755,7 +755,7 @@

# 82-UnitTest

100,,n,cases,bash 82-UnitTest/test.sh
101,,n,cases,bash 82-UnitTest/test.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While changing the priority from 100 to 101 correctly places the unit tests before other tests with priority 100, this approach is somewhat fragile. If another test is added in the future with a priority higher than 101, the unit tests will no longer run first, which would defeat the purpose of this change.

To make the intention clearer and more robust for the long term, consider using a significantly higher priority number. This would create a larger gap and clearly signal that these crucial, fast-feedback tests should always run first, reducing the chance of accidental reordering. For example, a priority of 200 could be used.

200,,n,cases,bash 82-UnitTest/test.sh

# 83-DocTest

Expand Down
1 change: 1 addition & 0 deletions test/ci/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -570,6 +570,7 @@ while [ $i -lt ${#hosts[*]} ]; do
run_thread $i $j &
j=$((j + 1))
done
sleep 1
i=$((i + 1))
done

Expand Down
Loading