Allow OkHttpClient overrides in Interceptor #9108
Conversation
| * Creates an [Address] of out of the provided [HttpUrl] | ||
| * that uses this client’s DNS, TLS, and proxy configuration. | ||
| */ | ||
| @Deprecated("Not intended to be public API on OkHttpClient") |
There was a problem hiding this comment.
Why not? I think this is out of scope for this PR.
There was a problem hiding this comment.
Because I'm removing the only caller, and I'm not sure we expect people to call it?
There was a problem hiding this comment.
Probably a bug that it’s here. But I don’t like deprecating stuff unless we’re going to remove it later, and I definitely don’t like removing stuff later. Ultimately I believe so much in this thing that I never want to break APIs, and we should have a stronger reason to deprecate something than ‘we don’t like it anymore’.
okhttp/src/commonJvmAndroid/kotlin/okhttp3/internal/http/RealInterceptorChain.kt
Outdated
Show resolved
Hide resolved
okhttp/src/commonJvmAndroid/kotlin/okhttp3/internal/http/RealInterceptorChain.kt
Outdated
Show resolved
Hide resolved
okhttp/src/commonJvmAndroid/kotlin/okhttp3/internal/http/RealInterceptorChain.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # okhttp/src/commonJvmAndroid/kotlin/okhttp3/internal/connection/RealCall.kt # okhttp/src/jvmTest/kotlin/okhttp3/internal/connection/RouteSelectorTest.kt
| unit: TimeUnit, | ||
| ): Chain | ||
|
|
||
| val dns: Dns |
There was a problem hiding this comment.
For provoking discussion, rather than the final set.
The advantage of Call.Decorator was we didn't need to copy all these properties.
we could
- start out small, and add as each is shown valuable.
- open all
- be opinionated based on our ideas
| * Creates an [Address] of out of the provided [HttpUrl] | ||
| * that uses this client’s DNS, TLS, and proxy configuration. | ||
| */ | ||
| @Deprecated("Not intended to be public API on OkHttpClient") |
There was a problem hiding this comment.
Probably a bug that it’s here. But I don’t like deprecating stuff unless we’re going to remove it later, and I definitely don’t like removing stuff later. Ultimately I believe so much in this thing that I never want to break APIs, and we should have a stronger reason to deprecate something than ‘we don’t like it anymore’.
|
|
||
| val connectionPool: ConnectionPool | ||
|
|
||
| fun withConnectionPool(connectionPool: ConnectionPool): Chain |
There was a problem hiding this comment.
Should we throw if you call this on a network interceptor, since you’re already connected?
2 participants
Alternative to #8800