-
Notifications
You must be signed in to change notification settings - Fork 9.2k
Allow OkHttpClient overrides in Interceptor #9108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yschimke
wants to merge
4
commits into
square:master
Choose a base branch
from
yschimke:with_dns
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+379
−7
Open
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
all fields
- Loading branch information
commit 7abf8eecd68c5105866ab29e5c46e4c5a130aa32
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,8 +16,14 @@ | |
| package okhttp3 | ||
|
|
||
| import java.io.IOException | ||
| import java.net.Proxy | ||
| import java.net.ProxySelector | ||
| import java.util.concurrent.TimeUnit | ||
| import javax.net.SocketFactory | ||
| import javax.net.ssl.HostnameVerifier | ||
| import javax.net.ssl.SSLSocketFactory | ||
| import javax.net.ssl.X509TrustManager | ||
| import okhttp3.internal.tls.CertificateChainCleaner | ||
|
|
||
| /** | ||
| * Observes, modifies, and potentially short-circuits requests going out and the corresponding | ||
|
|
@@ -110,8 +116,64 @@ fun interface Interceptor { | |
| unit: TimeUnit, | ||
| ): Chain | ||
|
|
||
| fun withDns(dns: Dns?): Chain | ||
| val dns: Dns | ||
|
|
||
| fun withSocketFactory(socketFactory: SocketFactory?): Chain | ||
| fun withDns(dns: Dns): Chain | ||
|
|
||
| val socketFactory: SocketFactory | ||
|
|
||
| fun withSocketFactory(socketFactory: SocketFactory): Chain | ||
|
|
||
| val retryOnConnectionFailure: Boolean | ||
|
|
||
| fun withRetryOnConnectionFailure(retryOnConnectionFailure: Boolean): Chain | ||
|
|
||
| val authenticator: Authenticator | ||
|
|
||
| fun withAuthenticator(authenticator: Authenticator): Chain | ||
|
|
||
| val cookieJar: CookieJar | ||
|
|
||
| fun withCookieJar(cookieJar: CookieJar): Chain | ||
|
|
||
| val cache: Cache? | ||
|
|
||
| fun withCache(cache: Cache): Chain | ||
|
|
||
| val proxy: Proxy? | ||
|
|
||
| fun withProxy(proxy: Proxy): Chain | ||
|
|
||
| val proxySelector: ProxySelector | ||
|
|
||
| fun withProxySelector(proxySelector: ProxySelector): Chain | ||
|
|
||
| val proxyAuthenticator: Authenticator | ||
|
|
||
| fun withProxyAuthenticator(proxyAuthenticator: Authenticator): Chain | ||
|
|
||
| val sslSocketFactory: SSLSocketFactory | ||
|
|
||
| fun withSslSocketFactory(sslSocketFactory: SSLSocketFactory): Chain | ||
|
|
||
| val x509TrustManager: X509TrustManager? | ||
|
|
||
| fun withX509TrustManager(x509TrustManager: X509TrustManager): Chain | ||
|
|
||
| val hostnameVerifier: HostnameVerifier | ||
|
|
||
| fun withHostnameVerifier(hostnameVerifier: HostnameVerifier): Chain | ||
|
|
||
| val certificatePinner: CertificatePinner | ||
|
|
||
| fun withCertificatePinner(certificatePinner: CertificatePinner): Chain | ||
|
|
||
| val certificateChainCleaner: CertificateChainCleaner? | ||
|
|
||
| fun withCertificateChainCleaner(certificateChainCleaner: CertificateChainCleaner): Chain | ||
|
|
||
| val connectionPool: ConnectionPool | ||
|
|
||
| fun withConnectionPool(connectionPool: ConnectionPool): Chain | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we throw if you call this on a network interceptor, since you’re already connected? |
||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For provoking discussion, rather than the final set.
The advantage of Call.Decorator was we didn't need to copy all these properties.
we could