Skip to content

dolphin: Fix the return type of SUM() #3223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

dolphin: Fix the return type of SUM() #3223

wants to merge 3 commits into from

Conversation

@Jille
Copy link
Contributor

@Jille Jille commented Feb 26, 2024

No description provided.

@Jille Jille force-pushed the dolphin-catalog-sum branch from 41ea794 to bce4318 Compare February 26, 2024 17:50
@kyleconroy
Copy link
Collaborator

Is this accurate? In PostgreSQL, SUM is polymorphic and returns the type of its input parameters.
@Jille
Copy link
Contributor Author

Jille commented Mar 24, 2024

Good point. I'll write it out for all types, just like the PostgreSQL catalog does.

However, picking the right function from the catalog doesn't seem to work yet (https://play.sqlc.dev/p/a09737c4aa272d364f56e1a9b5d24d1424a5cc6b5b29ad8da220990129db6c92).
@Jille Jille mentioned this pull request Apr 1, 2024
Open
@Jille Jille marked this pull request as draft April 16, 2024 12:13
@Jille Jille mentioned this pull request Oct 3, 2024
Open
@jozuenoon
Copy link

Hi! That would be very useful any chances to merge this?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@Jille @kyleconroy @jozuenoon