Skip to content

dolphin: Fix the return type of SUM() #3223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

dolphin: Fix the return type of SUM() #3223

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bce4318
dolphin: Fix the return type of SUM()
Jille Feb 26, 2024
e67403f
dolphin: Write out the sum catalog entry for multiple types
Jille Mar 24, 2024
eafc64a
Add tests that show the sum() functions aren't polymorphic yet
Jille Mar 24, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
dolphin: Write out the sum catalog entry for multiple types
  • Loading branch information
@Jille
Jille committed Mar 24, 2024
commit e67403f3990406e8d60d56b03740b5de23eb9aef
42 changes: 41 additions & 1 deletion internal/engine/dolphin/stdlib.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5195,14 +5195,54 @@ func defaultSchema(name string) *catalog.Schema {
},
ReturnType: &ast.TypeName{Name: "time"},
},
{
Name: "SUM",
Args: []*catalog.Argument{
{
Type: &ast.TypeName{Name: "int"},
},
},
ReturnType: &ast.TypeName{Name: "bigint"},
ReturnTypeNullable: true,
},
{
Name: "SUM",
Args: []*catalog.Argument{
{
Type: &ast.TypeName{Name: "bigint"},
},
},
ReturnType: &ast.TypeName{Name: "bigint"},
ReturnTypeNullable: true,
},
{
Name: "SUM",
Args: []*catalog.Argument{
{
Type: &ast.TypeName{Name: "float"},
},
},
ReturnType: &ast.TypeName{Name: "double"},
ReturnTypeNullable: true,
},
{
Name: "SUM",
Args: []*catalog.Argument{
{
Type: &ast.TypeName{Name: "double"},
},
},
ReturnType: &ast.TypeName{Name: "double"},
ReturnTypeNullable: true,
},
{
Name: "SUM",
Args: []*catalog.Argument{
{
Type: &ast.TypeName{Name: "any"},
},
},
ReturnType: &ast.TypeName{Name: "int"},
ReturnType: &ast.TypeName{Name: "any"},
ReturnTypeNullable: true,
},
{
Expand Down