Add charset option to js-api #1732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 24, 2022
Goodwine
approved these changes
Jun 28, 2022
Member
|
Test seems to be failing due to dart-lang/sdk#48272 so not at all related to this PR |
Contributor
Author
|
Maybe we should change the CI to run against stable/beta SDK, but not dev SDK. I think having beta SDK is already enough for catching issue early, having dev SDK is a little risky of running into SDK problems. |
Member
|
I discussed with @nex3 and we'll modify the CI script point I'll try the change here and then move the fix to a separate PR, sorry for the upcoming spammyness :) |
Contributor
Author
|
No problem. Feel free to push more commits for testing if needed. I will clean up this PR once the CI issue get resolved up in main. |
Member
|
yay it worked :) So once sass/sass-spec#1801 you can rebase/merge it on your sass-spec PR and it should now work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sass/sass#3242
Depends on:
See sass/sass-spec#1800