Add charset option

[ntkme]

sass/sass#3242

Depends on:

• Add charset option to js-api sass#3346
• Add charset option to js-api dart-sass#1732
• Add charset option embedded-protocol#96

See sass/embedded-host-node#152

[ntkme]

  Expected: '1.53.0'
    Actual: '1.54.0-dev'
     Which: is different.
            Expected: 1.53.0
              Actual: 1.54.0-dev
                         ^
             Differ at offset 3

@Goodwine Should I update the dart-sass dependency version to 1.54.0-dev?

BTW, you can git commit --allow-empty to create empty commits that will trigger github events.

[Goodwine]

ah.. thanks for the tip 😅

And yes, please update the version on both the dependency and the package itself, thanks!

[Goodwine]

discussing with @nex3 the failures on JS API Tests shouldn't be happening, I'll take a look here as well :)

[ntkme]

@Goodwine I found the CI had an incorrect clone path for dart-sass and was able to fix that. However JS API Tests now fails with some TS type checking:

node_modules/@types/tar/index.d.ts:252:36 - error TS2709: Cannot use namespace 'MiniPass' as a type.
252 export interface ReadEntry extends MiniPass, HeaderProperties {
                                   ~~~~~~~~
Found 1 error in node_modules/@types/tar/index.d.ts:252

@nex3 I thought this is already fixed in sass/embedded-host-node@d6dbd87, any ideas why CI is failing?

[ntkme]

Ok turns out I did not rebase sass/embedded-host-node#152 to the latest.

[ntkme]

@Goodwine Now CI fails with creating a symlink on windows only, for which I have no idea about. Otherwise, everything seems to be ok.

[ntkme]

Tried to replace ln -s with cp -R and it still fails on windows for some unknown reason, changed again to mv and now it seems to work.

[Goodwine]

Thanks for diving and fixing the errors, it's very interesting how it used to work but not anymore lol, but the changes look reasonable :)