-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add approach_velocity_scaling_dist to dynamic parameter callback #5711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add approach_velocity_scaling_dist to dynamic parameter callback #5711
Conversation
|
@brammmieee Please check the build error: https://app.circleci.com/pipelines/github/ros-navigation/navigation2/16812/workflows/d927e01c-8538-4765-8795-10813d7c8c85/jobs/49285 Also, please sign with DCO |
8111a30 to
d4b31d1
Compare
The approach_velocity_scaling_dist parameter was declared and initialized but missing from the dynamicParametersCallback function, preventing it from being updated via dynamic reconfigure (e.g., rqt_reconfigure). This commit adds the parameter to the callback handler, enabling runtime reconfiguration like other controller parameters. Signed-off-by: Bram Odrosslij <bram.odros@gmail.com>
Signed-off-by: Bram Odrosslij <bram.odros@gmail.com>
d4b31d1 to
1fbb8df
Compare
Codecov Report❌ Patch coverage is
... and 13 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add to the tests so we exercise the code for coverage https://github.com/ros-navigation/navigation2/blob/main/nav2_regulated_pure_pursuit_controller/test/test_regulated_pp.cpp#L425-L521. Should be a 2 line change.
|
@brammmieee please sign with DCO :) |
Signed-off-by: Bram Odrosslij <bram.odros@gmail.com>
25ed4f5 to
b841330
Compare
Basic Info
Description of contribution in a few bullet points
approach_velocity_scaling_distparameter indynamicParametersCallbackfunctionDescription of documentation updates required from your changes
Description of how this change was tested
rqt_reconfigureduring runtimecolcon testFuture work that may be required in bullet points
For Maintainers:
backport-humble,backport-iron.