-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add a parameter to set initial enabled state for the collision monitor #5554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SteveMacenski
merged 6 commits into
ros-navigation:main
from
armgits:collision-monitor-enable-parameter
Sep 26, 2025
Merged
Add a parameter to set initial enabled state for the collision monitor #5554
SteveMacenski
merged 6 commits into
ros-navigation:main
from
armgits:collision-monitor-enable-parameter
Sep 26, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…monitor Signed-off-by: Abhishekh Reddy <helloarm@pm.me>
Signed-off-by: Abhishekh Reddy <helloarm@pm.me>
Codecov Report�� All modified and coverable lines are covered by tests.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Signed-off-by: Abhishekh Reddy <helloarm@pm.me>
SteveMacenski
requested changes
Sep 26, 2025
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Abhishekh Reddy <helloarm@pm.me>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Abhishekh Reddy <helloarm@pm.me>
Signed-off-by: Abhishekh Reddy <helloarm@pm.me>
SteveMacenski
approved these changes
Sep 26, 2025
Member
|
@armgits please open a docs PR to add this to the configuration guide for the monitor. Then I can merge the pair once CI passes |
Contributor
Author
|
On it! |
SakshayMahna
pushed a commit
to SakshayMahna/navigation2
that referenced
this pull request
Oct 4, 2025
ros-navigation#5554) * Added a new parameter to set initial enabled state for the collision monitor Signed-off-by: Abhishekh Reddy <helloarm@pm.me> * Fixed enabled_at_start parameter default value Signed-off-by: Abhishekh Reddy <helloarm@pm.me> * Updated toggle service unit test for code coverage Signed-off-by: Abhishekh Reddy <helloarm@pm.me> * Updated enabled state log message on startup Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Abhishekh Reddy <helloarm@pm.me> * Updated enabled state log message on startup Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Abhishekh Reddy <helloarm@pm.me> * Renamed parameter to 'enabled' Signed-off-by: Abhishekh Reddy <helloarm@pm.me> --------- Signed-off-by: Abhishekh Reddy <helloarm@pm.me> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
silanus23
pushed a commit
to silanus23/navigation2
that referenced
this pull request
Oct 10, 2025
ros-navigation#5554) * Added a new parameter to set initial enabled state for the collision monitor Signed-off-by: Abhishekh Reddy <helloarm@pm.me> * Fixed enabled_at_start parameter default value Signed-off-by: Abhishekh Reddy <helloarm@pm.me> * Updated toggle service unit test for code coverage Signed-off-by: Abhishekh Reddy <helloarm@pm.me> * Updated enabled state log message on startup Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Abhishekh Reddy <helloarm@pm.me> * Updated enabled state log message on startup Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Abhishekh Reddy <helloarm@pm.me> * Renamed parameter to 'enabled' Signed-off-by: Abhishekh Reddy <helloarm@pm.me> --------- Signed-off-by: Abhishekh Reddy <helloarm@pm.me> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
silanus23
pushed a commit
to silanus23/navigation2
that referenced
this pull request
Oct 11, 2025
ros-navigation#5554) * Added a new parameter to set initial enabled state for the collision monitor Signed-off-by: Abhishekh Reddy <helloarm@pm.me> * Fixed enabled_at_start parameter default value Signed-off-by: Abhishekh Reddy <helloarm@pm.me> * Updated toggle service unit test for code coverage Signed-off-by: Abhishekh Reddy <helloarm@pm.me> * Updated enabled state log message on startup Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Abhishekh Reddy <helloarm@pm.me> * Updated enabled state log message on startup Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Abhishekh Reddy <helloarm@pm.me> * Renamed parameter to 'enabled' Signed-off-by: Abhishekh Reddy <helloarm@pm.me> --------- Signed-off-by: Abhishekh Reddy <helloarm@pm.me> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
Description of how this change was tested
Future work that may be required in bullet points
--
For Maintainers:
backport-*.