Skip to content

Conversation

@armgits
Copy link
Contributor

@armgits armgits commented Sep 26, 2025


Basic Info

Info Please fill out this column
Ticket(s) this addresses #5493
Primary OS tested on Ubuntu
Robotic platform tested on Turtlebot 3 Loopback Simulation
Does this PR contain AI generated software? No
Was this PR description generated by AI software? No

Description of contribution in a few bullet points

  • Added a parameter to set the initial state for for the collision monitor to start in enabled/disabled state.

Description of documentation updates required from your changes

Description of how this change was tested

  • This change was tested in the TB3 Loopback simulation to check if it actually works. I kept an eye on the console log to see if the correct message was printed during node configuration. I also tried modifying the parameter in the parameters file within the bring up package to see if the changes were applied correctly.

Future work that may be required in bullet points

--

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists
  • Should this be backported to current distributions? If so, tag with backport-*.
…monitor

Signed-off-by: Abhishekh Reddy <helloarm@pm.me>
Signed-off-by: Abhishekh Reddy <helloarm@pm.me>
@codecov
Copy link

codecov bot commented Sep 26, 2025

Codecov Report

�� All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
...2_collision_monitor/src/collision_monitor_node.cpp 97.23% <100.00%> (+0.04%) ⬆️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Signed-off-by: Abhishekh Reddy <helloarm@pm.me>
armgits and others added 3 commits September 26, 2025 12:27
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Abhishekh Reddy <helloarm@pm.me>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Abhishekh Reddy <helloarm@pm.me>
Signed-off-by: Abhishekh Reddy <helloarm@pm.me>
@SteveMacenski
Copy link
Member

SteveMacenski commented Sep 26, 2025

@armgits please open a docs PR to add this to the configuration guide for the monitor. Then I can merge the pair once CI passes

@armgits
Copy link
Contributor Author

armgits commented Sep 26, 2025

On it!

@SteveMacenski SteveMacenski merged commit 4e5273a into ros-navigation:main Sep 26, 2025
16 checks passed
SakshayMahna pushed a commit to SakshayMahna/navigation2 that referenced this pull request Oct 4, 2025
ros-navigation#5554)

* Added a new parameter to set initial enabled state for the collision monitor

Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

* Fixed enabled_at_start parameter default value

Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

* Updated toggle service unit test for code coverage

Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

* Updated enabled state log message on startup

Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

* Updated enabled state log message on startup

Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

* Renamed parameter to 'enabled'

Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

---------

Signed-off-by: Abhishekh Reddy <helloarm@pm.me>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
silanus23 pushed a commit to silanus23/navigation2 that referenced this pull request Oct 10, 2025
ros-navigation#5554)

* Added a new parameter to set initial enabled state for the collision monitor

Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

* Fixed enabled_at_start parameter default value

Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

* Updated toggle service unit test for code coverage

Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

* Updated enabled state log message on startup

Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

* Updated enabled state log message on startup

Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

* Renamed parameter to 'enabled'

Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

---------

Signed-off-by: Abhishekh Reddy <helloarm@pm.me>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
silanus23 pushed a commit to silanus23/navigation2 that referenced this pull request Oct 11, 2025
ros-navigation#5554)

* Added a new parameter to set initial enabled state for the collision monitor

Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

* Fixed enabled_at_start parameter default value

Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

* Updated toggle service unit test for code coverage

Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

* Updated enabled state log message on startup

Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

* Updated enabled state log message on startup

Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

* Renamed parameter to 'enabled'

Signed-off-by: Abhishekh Reddy <helloarm@pm.me>

---------

Signed-off-by: Abhishekh Reddy <helloarm@pm.me>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants