Skip to content

Fixing builds for message filters API change while retaining Jazzy, Kilted, and Rolling support #5251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 11, 2025
Merged

Fixing builds for message filters API change while retaining Jazzy, Kilted, and Rolling support #5251

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b99b7fc
Update amcl_node.hpp
SteveMacenski Jun 10, 2025
bd2e08b
Update amcl_node.cpp
SteveMacenski Jun 10, 2025
dfafef1
Working for Kilted, Jazzy
SteveMacenski Jun 11, 2025
9345ed3
Update amcl_node.cpp
SteveMacenski Jun 11, 2025
a780031
Update amcl_node.cpp
SteveMacenski Jun 11, 2025
20856b8
Update amcl_node.cpp
SteveMacenski Jun 11, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update amcl_node.cpp 
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
  • Loading branch information
@SteveMacenski
SteveMacenski authored Jun 11, 2025
commit 9345ed3467ac22bd7a58c9c36a255586f7dd8ff1
2 changes: 1 addition & 1 deletion nav2_amcl/src/amcl_node.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1529,7 +1529,7 @@ AmclNode::initMessageFilters()
shared_from_this(), scan_topic_, rclcpp::SensorDataQoS(), sub_opt);
#else
laser_scan_sub_ = std::make_unique<message_filters::Subscriber<sensor_msgs::msg::LaserScan,
nav2::LifecycleNode>>(
rclcpp_lifecycle::LifecycleNode>>(
shared_from_this(), scan_topic_, rmw_qos_profile_sensor_data, sub_opt);
#endif

Expand Down
Loading