Merge main into humble_main #5108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add pre-commit Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> * Add codespell workflow Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> * Codespell write_changes=false. As otherwise CI does not fail. Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> * Configure isort Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> * add precommit Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> * Introducing some issues. Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> * Revert "Introducing some issues." This reverts commit 5377b65. Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> * Removing pre-commit workflow. Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> * Fix formatting error Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> * Merge remote-tracking branch 'origin/main' into precommit Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> * Change v31 to v32 Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> * Revert "Merge remote-tracking branch 'origin/main' into precommit" This reverts commit 8a7ca39. Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> * Rm submodule Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> * pre-commit run --all after merge Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> --------- Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com>
Signed-off-by: Tatsuro Sakaguchi <tatsuro.sakaguchi@g.softbank.co.jp>
The definition of the slot was removed in commit e6f500e ("nav2_rviz_plugins: Remove slots without implementation (ros-navigation#4974)", 2025-03-10), because it had no implementation. But we forgot to remove the reference to this slot, because the compiler cannot detect it. We remove the reference now. Without this, rviz shows warnings like: QObject::connect: No such slot nav2_rviz_plugins::CostmapCostTool::updateAutoDeactivate() QObject::connect: (sender name: 'Single click') Signed-off-by: Michal Sojka <michal.sojka@cvut.cz>
…igation#5006) * * Parametrize collision checking in nav2_graceful_controller Signed-off-by: suchetanrs <suchetan.saravanan@gmail.com> * * Fix linting errors Signed-off-by: suchetanrs <suchetan.saravanan@gmail.com> * * Address PR comments * Add parameter to dynamic reconfigure Signed-off-by: suchetanrs <suchetan.saravanan@gmail.com> * * Add test for the use_collision_detection parameter Signed-off-by: suchetanrs <suchetan.saravanan@gmail.com> --------- Signed-off-by: suchetanrs <suchetan.saravanan@gmail.com>
* Update smac planner types Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Test ament_mypy Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add packages Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Fix arg name Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Add ** Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * Specific package Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * re-run ci Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> * re-run ci Signed-off-by: Michael Carlstrom <rmc@carlstrom.com> --------- Signed-off-by: Michael Carlstrom <rmc@carlstrom.com>
…n#5023) Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Yancey <135342560+Yancey2023@users.noreply.github.com>
* Configured mypy strict on nav2_smac_planner. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Modify workflow to contain mypy configuration. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Added dependency for type support Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> --------- Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
* Configured mypy for nav2_common Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Added nav2_common to the workflow. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Removed all instances of Any. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Fixed unsafe fixes using ruff. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> --------- Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
…on#5010) * Migrate costmap bound check to clearArea for STVL override Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Added unbounded map to world function. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Added test for mapToWorldNoBounds Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> --------- Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
…s in MPPI critics (ros-navigation#4996) * Add warning when settings not aligned; Add tunable option for near collision Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Linting Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Add more information for warning Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Add test for coverage Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Throw controller exception instead of invalid argument Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
…5029) * Added pre-commit with ament ignores to the workflow. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Removed codespell from workflow and enabled write changes in pre-commit. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Update pull request template with a testing description section. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> --------- Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
…avigation#5034) * feat(nav2_rotation_shim_controller): add use_path_orientations Signed-off-by: Kemal Bektas <kemal.bektas@node-robotics.com> * Update nav2_rotation_shim_controller/src/nav2_rotation_shim_controller.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Kemal Bektas <kemal.bektas@node-robotics.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Kemal Bektas <kemal.bektas@node-robotics.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
* Configured nav2_bringup to be compatible with mypy. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Added nav2_bringup to the linting workflow. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> --------- Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
* Add service introspection for client and server side, more tests to go Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Add test for service server, fix repeat declaration Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix cpplint Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Add test for coverage Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Declare and set the parameter in service client and server class Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Add typedef; Fix costmap cost tool and bt service Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Rebase; Add tests for coverage Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix costmap cost tool; Typedef Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Cleanup Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Add spin thread Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Add spin Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Change spin thread to internal executor Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Use rclcpp spin when no internal executor Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Update nav2_util/include/nav2_util/service_client.hpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_util/include/nav2_util/service_client.hpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_util/include/nav2_util/service_client.hpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_util/include/nav2_util/service_client.hpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Refactor Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Update nav2_util/include/nav2_util/service_client.hpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
* Configured nav2_collision_monitor to use mypy strict. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Added nav2_collision_monitor to the workflow. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> --------- Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
* Configured mypy to run on the costmap_2d package. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Added mypy_nav2_costmap_2d to the workflow. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> --------- Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
…avigation#5027) * Halt recovery action when main action succeeds to reset status Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_behavior_tree/plugins/control/recovery_node.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
* Define attributes for nav2_msgs. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Configured opennav_docking to use strict mypy. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Added opennav_docking to the mypy linting workflow. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> --------- Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
* Clean set port Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Remove set Signed-off-by: Alberto Tudela <ajtudela@gmail.com> --------- Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
* Configured nav2_lifecycle_manager to be compatible with mypy Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Added nav2_lifecycle_manager to the workflow. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> --------- Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Signed-off-by: Johannes Plapp <johannes.plapp@logivations.com>
* Configured nav2_loopback_sim to be compatible with mypy. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Added nav2_loopback_sim to the workflow. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Separated packages from list for mypy workflow. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> --------- Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
* Add constraint; fix settings Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Add lower and upper bound Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Update tests Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Update nav2_mppi_controller/include/nav2_mppi_controller/motion_models.hpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_mppi_controller/include/nav2_mppi_controller/motion_models.hpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_mppi_controller/include/nav2_mppi_controller/motion_models.hpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_mppi_controller/include/nav2_mppi_controller/motion_models.hpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
* Configured nav2_map_server to be mypy compliant. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Added nav2_map_server to the mypy workflow. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> --------- Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
…ation#5057) * Publishing a full MPPI trajectory if desirable Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * only create publisher when needed Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * adjust topics Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Moving for lint Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * updating topics in tests Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
* Add a double spin Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Add comment Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Move spin to constructor Signed-off-by: Alberto Tudela <ajtudela@gmail.com> --------- Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
There remained a duplicate test of test_system_launch after Groot monitoring was removed Signed-off-by: Rasmus Larsson <rasmus.larsson@accenture.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
* Added most nav2_simple_commander files that can be trivially converted to be mypy compatible. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Modified edge cases and types for robot_navigator to pass mypy checks. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Added nav2_simple_commander to the linting workflow. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Added logs and ignored type errors due to spins w/o timeout. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> --------- Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
…ion. (fix ros-navigation#4846) (ros-navigation#4994) * Add WaypointStatus message type & Remove MissedWaypoint message type Signed-off-by: zz990099 <771647586@qq.com> * Add waypoint_statuses records in RemoveInCollisionGoals/RemovePassedGoals actions Signed-off-by: zz990099 <771647586@qq.com> * Add validation tests Signed-off-by: zz990099 <771647586@qq.com> * Make NavigateThroughPoses navigator report waypoint statuses information Signed-off-by: zz990099 <771647586@qq.com> * Make WaypointFollower use WaypointStatus message type in action result Signed-off-by: zz990099 <771647586@qq.com> * Split MISSED status into SKIPPED & FAILED Signed-off-by: zz990099 <771647586@qq.com> * fix edge case handle in RemoveInCollision/RemovePassed BT actions Signed-off-by: zz990099 <771647586@qq.com> * Add validation test cases for RemoveInCollision&RemovePassed BT actions Signed-off-by: zz990099 <771647586@qq.com> * Update RemovePassedGoals/RemoveInCollisionGoals node in Groot XML Signed-off-by: zz990099 <771647586@qq.com> --------- Signed-off-by: zz990099 <771647586@qq.com>
* Revert removing live groot monitoring from Nav2 (ros-navigation#2696) Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Update to Groot2 Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added JSON conversions Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Fix rebase Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Update to nav_msgs::Goals Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added nav_msgs to json utils Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Add register to types Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Fix null-dereference Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added Json test Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Fix some tests Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Fix flake Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Update package dependency Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Minor fixes Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Fix test Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Rename groot_publisher_port parameter to groot_server_port Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Minor fix in tst Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added JSON for waypoint_status Signed-off-by: Alberto Tudela <ajtudela@gmail.com> --------- Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
) * Fix incorrect world <-> map coordinates conversions The conversion between world and map continuous (!) coordinates do not require a +/-0.5. This offset is only required when converting discrete map cell indexes to the coordinates of its center. Signed-off-by: Dylan De Coeyer <dylan.decoeyer@quimesis.be> * nav2_smac_planner: fix smoother test when path is in collision The added pose was indeed invalid, but the it was ignored by the smoother, since considered as a cusp. Instead, let's make the end of the plan invalid as it won't be ignored. Also, let's duplicate the last pose to make the orientation estimation fail, rather than adding a new arbitrary pose. Signed-off-by: Dylan De Coeyer <dylan.decoeyer@quimesis.be> --------- Signed-off-by: Dylan De Coeyer <dylan.decoeyer@quimesis.be>
…on#4941) * index lookup and comparator optimisation Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * lint Signed-off-by: Guillaume Doisy <guillaume@dexory.com> --------- Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com>
* Add warning to some of the nodes Signed-off-by: Adi Vardi <adi.vardi@enway.ai> * remove unused includes Signed-off-by: Adi Vardi <adi.vardi@enway.ai> * Add warning to remaining nodes using isStatusActive to initialize Signed-off-by: Adi Vardi <adi.vardi@enway.ai> * Change to note & update phrsing Signed-off-by: Adi Vardi <adi.vardi@enway.ai> * replace reset by re-initialize Signed-off-by: Adi Vardi <adi.vardi@enway.ai> --------- Signed-off-by: Adi Vardi <adi.vardi@enway.ai>
* for LikelihoodFieldModel Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * for LikelihoodFieldModelProb Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * typo Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * init max_occ_dist in map.c and remove unnecessary condition Signed-off-by: Guillaume Doisy <guillaume@dexory.com> --------- Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com>
Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
* Remove duplicate code Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Add twist validation for controller server Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
* Add IsStoppedBTNode Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * add topic name + reformat Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * fix comment Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * fix abs Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * remove log Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * add getter functions for raw twist Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * remove unused code Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * use odomsmoother Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * fix formatting Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * update groot Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * Add test Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * reset at success Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * FIX velocity_threshold_ Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * Fix stopped Node Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * Add tests to odometry_utils Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * fix linting Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * lock costmap Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * improvement Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * remove spacing Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * remove unlock Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> --------- Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>
* Configured nodes of nav2_system_tests to be mypy compliant. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Configured launch files of nav2_system_tests to be mypy compliant. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Added nav2_system_tests to the linting workflow. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> --------- Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
* Configured tools to be mypy compliant. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Added mypy as a pre-commit hook. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> * Simplified workflow by including all packages with mypy. Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com> --------- Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
* redesign dynamic param patterns Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> * change cache version Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> * check that parameter of type double are >=0.0 Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com> --------- Signed-off-by: Nils-ChristianIseke <nilsmailiseke@gmail.com>
…ction (ros-navigation#4925) * Add force_use_current_pose Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * xml update Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * rename to use_start Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * lint Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * descriptions Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * simplify logic Signed-off-by: Guillaume Doisy <guillaume@dexory.com> --------- Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com>
… string (ros-navigation#4926) * [CostmapTopicCollisionChecker] Alternative constructor with footprint Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * raw pointer Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * suggestions from review Signed-off-by: Guillaume Doisy <guillaume@dexory.com> --------- Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com>
…gation#5092) * merged changes from humble for goal.header fix * reverted back, error in merge * ported goal.header fix in navfn_planner.cpp from humble * reverted to navfn_planner.cpp to origin/main * merged navfn_planner.cpp from humble * fixed the merge
* Replace dock_backwards_ param with dock plugin function Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Deprecated dock_backwards warning Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Convert dockDirection from bool to enum Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Minor fixes Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Improve deprecated param handling Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Set default to forward Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added tests Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Update nav2_docking/README.md Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Upper and others Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Revert declare_parameters_from_overrides Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added throw on configure plugin Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Remove node_utils Signed-off-by: Alberto Tudela <ajtudela@gmail.com> --------- Signed-off-by: Alberto Tudela <ajtudela@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
…-navigation#5071) * Update map_io library to use opencv method for faster map loading Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Update pre-commit config changes Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Use Eigen approach instead of OpenCV Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Update pre-commit changes Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Update include header include order Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Remove intermediary alpha matrix Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Add comments for the code understanding Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Fix else braces rule issue Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Create and use alpha_matrix when applying mask Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Update pre-commit changes Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Take flip part out of if-else Signed-off-by: Vignesh T <vignesh.t@kabam.ai> * Update pre-commit changes Signed-off-by: Vignesh T <vignesh.t@kabam.ai> --------- Signed-off-by: Vignesh T <vignesh.t@kabam.ai>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
* Add dock_database tests Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Add utils test Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Improve filter tests Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Added simple charging tests Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Improve comments Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Fix backward and redo main test Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Change test period to reduce test time Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Revert "Change test period to reduce test time" This reverts commit ef1555e. Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Delete print pose Signed-off-by: Alberto Tudela <ajtudela@gmail.com> --------- Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
Contributor
|
@coderwyvern, all pull requests must be targeted towards the |
Signed-off-by: coderwyvern <saudintantrimain@gmail.com>
Author
|
I ran |
This was referenced Apr 27, 2025
SteveMacenski
approved these changes
Apr 28, 2025
SteveMacenski
merged commit 1a07de6
into
ros-navigation:humble_main
9 of 12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
21 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the main into humble_main to allow humble_main to have the fixes in the last 3-4 weeks,