Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Simplified workflow by including all packages with mypy.
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
  • Loading branch information
leander-dsouza committed Apr 12, 2025
commit c284c61756ceb295add7d6220802ff501b5773ff
36 changes: 7 additions & 29 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,43 +11,20 @@ jobs:
strategy:
fail-fast: false
matrix:
linter: [xmllint, cpplint, uncrustify, pep257, flake8]
linter: [xmllint, cpplint, uncrustify, pep257, flake8, mypy]
steps:
- uses: actions/checkout@v4
- uses: ros-tooling/action-ros-lint@v0.1
with:
linter: ${{ matrix.linter }}
distribution: rolling
package-name: "*"

ament_lint_mypy:
name: ament_mypy
runs-on: ubuntu-latest
container:
image: rostooling/setup-ros-docker:ubuntu-noble-ros-rolling-ros-base-latest
steps:
- uses: actions/checkout@v4

- name: Install typeshed
- name: Install typeshed for mypy
if: matrix.linter == 'mypy'
run: sudo apt update && sudo apt install -y python3-typeshed

- uses: ros-tooling/action-ros-lint@v0.1
with:
linter: mypy
linter: ${{ matrix.linter }}
distribution: rolling
package-name: >-
nav2_smac_planner
nav2_common
nav2_bringup
nav2_collision_monitor
nav2_costmap_2d
opennav_docking
nav2_lifecycle_manager
nav2_loopback_sim
nav2_map_server
nav2_simple_commander
nav2_system_tests
arguments: --config tools/pyproject.toml
package-name: "*"
arguments: ${{ matrix.linter == 'mypy' && '--config tools/pyproject.toml' || '' }}

pre-commit:
name: pre-commit
Expand All @@ -64,3 +41,4 @@ jobs:
ament_xmllint,
ament_flake8,
ament_pep257,
ament_mypy
Loading