Added RPP use_cancel_deceleration parameter #4441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jatin Patil <jatinpatil2003@gmail.com>
JatinPatil2003
force-pushed
the
RPP_deceleration_4238
branch
from
2c173be to
6a4a4d5
Compare
Signed-off-by: Jatin Patil <jatinpatil2003@gmail.com>
padhupradheep
approved these changes
Jun 18, 2024
Member
padhupradheep
left a comment
padhupradheep
left a comment
There was a problem hiding this comment.
LGTM! Tested it as well!
Great job @JatinPatil2003 Thanks for the contribution
Member
|
@JatinPatil2003 Could you please also give in a PR for the documentation? Then we can get this inn.. Thanks! |
Contributor
Author
|
I have opened a PR for documentation ros-navigation/docs.nav2.org/pull/567 |
SteveMacenski
approved these changes
Jun 18, 2024
Member
|
Thanks @JatinPatil2003 and @padhupradheep - great contributions! |
Member
|
was about to press merge @SteveMacenski :-D |
Marc-Morcos
pushed a commit
to Marc-Morcos/navigation2
that referenced
this pull request
Jul 4, 2024
* Added RPP use_cancel_deceleration parameter Signed-off-by: Jatin Patil <jatinpatil2003@gmail.com> * Fixed Linting code style Signed-off-by: Jatin Patil <jatinpatil2003@gmail.com> --------- Signed-off-by: Jatin Patil <jatinpatil2003@gmail.com>
Manos-G
pushed a commit
to Manos-G/navigation2
that referenced
this pull request
Aug 1, 2024
* Added RPP use_cancel_deceleration parameter Signed-off-by: Jatin Patil <jatinpatil2003@gmail.com> * Fixed Linting code style Signed-off-by: Jatin Patil <jatinpatil2003@gmail.com> --------- Signed-off-by: Jatin Patil <jatinpatil2003@gmail.com>
masf7g
pushed a commit
to quasi-robotics/navigation2
that referenced
this pull request
Oct 23, 2024
* Added RPP use_cancel_deceleration parameter Signed-off-by: Jatin Patil <jatinpatil2003@gmail.com> * Fixed Linting code style Signed-off-by: Jatin Patil <jatinpatil2003@gmail.com> --------- Signed-off-by: Jatin Patil <jatinpatil2003@gmail.com>
stevedanomodolor
pushed a commit
to stevedanomodolor/navigation2
that referenced
this pull request
Apr 29, 2025
* Added RPP use_cancel_deceleration parameter Signed-off-by: Jatin Patil <jatinpatil2003@gmail.com> * Fixed Linting code style Signed-off-by: Jatin Patil <jatinpatil2003@gmail.com> --------- Signed-off-by: Jatin Patil <jatinpatil2003@gmail.com> Signed-off-by: stevedanomodolor <stevedan.o.omodolor@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Future work that may be required in bullet points
For Maintainers: