Skip to content

Lifecycle manager with respawn option + adding respawn options in launch #2910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Apr 18, 2022
Merged

Lifecycle manager with respawn option + adding respawn options in launch #2910

merged 13 commits into from
Apr 18, 2022

Conversation

@SteveMacenski
Copy link
Member

@SteveMacenski SteveMacenski commented Apr 11, 2022 •
edited
Loading

#2752

Needs

  • Testing / validation of functionality: non-composed
  • Testing / validation of functionality: Composition -- No support, since all in the same process if 1 thing dies, it brings down everything including the lifecycle manager. Even if the composition container respawns, it won't respawn with its prior components so it will need to be manually reloaded.
  • Launch configuration respected -- handled in newest releases that haven't been yet made available in binaries, but will shortly
  • Docs: new parameters (bond_respawn_max_duration 10.0, attempt_respawn_reconnection true) + new launch configuration (use_respawn) + migration guide (added support for respawn, default off, only for non-composed)
  • Test coverage / CI testing
@SteveMacenski SteveMacenski mentioned this pull request Apr 11, 2022
Closed
This was referenced Apr 12, 2022
Closed
Merged
@SteveMacenski SteveMacenski merged commit 3e4dd6f into main Apr 18, 2022
@SteveMacenski SteveMacenski deleted the 2752 branch April 18, 2022 22:46
redvinaa pushed a commit to EnjoyRobotics/navigation2 that referenced this pull request Jun 30, 2022
@SteveMacenski @redvinaa
Lifecycle manager with respawn option + adding respawn options in lau…
472f9e7 
…nch (ros-navigation#2910)

* updated launch files for respawn options

* adding respawn capabilities to lifecycle manager

* closer to working

* updates for get_state (still WIP)

* working lifecycle manager + respawn

* adding delay

* more context in description of launch configurationg

* adding lint exception

* Update config.yml

* fixing CI issues
savalena pushed a commit to savalena/navigation2 that referenced this pull request Jul 5, 2024
@SteveMacenski
Lifecycle manager with respawn option + adding respawn options in lau…
c471bfa 
…nch (ros-navigation#2910)

* updated launch files for respawn options

* adding respawn capabilities to lifecycle manager

* closer to working

* updates for get_state (still WIP)

* working lifecycle manager + respawn

* adding delay

* more context in description of launch configurationg

* adding lint exception

* Update config.yml

* fixing CI issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@SteveMacenski