refactor(jtc): improve jtc tolerances #2133
Open
+523
−189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses the following:
- Seperate declaration from definition for better compilation
speed and readability.
- Add new function (create_error_trajectory_point).
- Add extensive doxygen-style comments.
- Add tests for new function (create_error_trajectory_point).
github-actions
bot
requested review from
MarqRazz,
aprotyas,
bijoua29,
christophfroehlich and
mhubii
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2133 +/- ##
==========================================
+ Coverage 84.80% 84.91% +0.11%
==========================================
Files 151 152 +1
Lines 14660 14694 +34
Branches 1272 1278 +6
==========================================
+ Hits 12433 12478 +45
+ Misses 1766 1759 -7
+ Partials 461 457 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello respected maintainers and reviewers!
This is Surya!
This PR addresses the following:
If you have question, why I moved (or seperated) it to tolerances.cpp it is because the file was getting way too long for no reason. It would both increase compile time and future maintainance.
If you have question, why I added
create_error_trajectory_pointit is because we can calculate the current error point and then compare it with tolerances with ease!A note: This is a continuation of the previous PR #2048 (closed now). Instead of doing new features (new tolerances option) and refactoring in one PR. I split them into 2 PRs one doing refactoring (current) and another future PR adding feature.