Skip to content

Fix: Quote Python path to handle spaces in postinstall scripts #5366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
alex-lisi wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix: Quote Python path to handle spaces in postinstall scripts #5366

alex-lisi wants to merge 2 commits into from
+6 −2

Conversation

@alex-lisi
Copy link
Contributor

@alex-lisi alex-lisi commented Jan 24, 2026

Description

Fixes installation failure when Python is installed in a directory containing spaces (e.g., C:\Program Files\Python37\).

Changes

  • Modified call_pkg_script() in platformio/package/manager/base.py to wrap the Python executable path in quotes when it contains spaces
  • Added isinstance(cmd, list) check before accessing list elements (addresses feedback from Fix: Quote Python path to handle spaces in postinstall scripts #5363)
  • This prevents the shell from incorrectly splitting the path during postinstall script execution

Testing

Related Issue

Fixes #5361

Notes

This is a revised version of #5363 incorporating maintainer feedback.
@alex-lisi
Fix: Quote Python path to handle spaces in postinstall scripts
ad88833 
Wraps Python executable path in quotes when it contains spaces before executing package postinstall scripts. This fixes installation failures on Windows when Python is installed in directories like 'Program Files'.

Fixes #5361
@alex-lisi
Check if cmd is list before accessing elements
17bd151
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@alex-lisi