Skip to content

Fix: Quote Python path to handle spaces in postinstall scripts #5363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alex-lisi wants to merge 1 commit into from
Closed

Fix: Quote Python path to handle spaces in postinstall scripts #5363

alex-lisi wants to merge 1 commit into from
+5 −1

Conversation

@alex-lisi
Copy link
Contributor

@alex-lisi alex-lisi commented Jan 21, 2026

Description

Fixes installation failure when Python is installed in a directory containing spaces (e.g., C:\Program Files\Python37\).

Changes

  • Modified call_pkg_script() in platformio/package/manager/base.py to wrap the Python executable path in quotes when it contains spaces
  • This prevents the shell from incorrectly splitting the path during postinstall script execution

Testing

Related Issue

Fixes #5361
@alex-lisi
Fix: Quote Python path to handle spaces in postinstall scripts
ad88833 
Wraps Python executable path in quotes when it contains spaces before executing package postinstall scripts. This fixes installation failures on Windows when Python is installed in directories like 'Program Files'.

Fixes #5361
@ivankravets
Copy link
Member

ivankravets commented Jan 21, 2026

The recommended way to declare the commdn is LIST type. See

platformio-core/platformio/package/manager/base.py

Line 332 in d6141b3

if not isinstance(cmd, list):

@alex-lisi alex-lisi mentioned this pull request Jan 24, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@alex-lisi @ivankravets