Do not activate review mode for closed or merged PR #3021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@alexr00 Hello, can you review it please? |
alexr00
requested changes
Oct 28, 2021
alexr00
approved these changes
Nov 2, 2021
Member
alexr00
left a comment
alexr00
left a comment
There was a problem hiding this comment.
Looks good, thank you! I will merge after we have released the next version later this week.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3009
Initially I tried to use line 312
this._prNumber = undefined;to disable review mode from previously branch, however withthis.clear(true);all seems to work fine.Probably that line should also be changed, but I'm not sure how to make pr "notResolved".
I tested manually those scenarios: