refactor(scripts): consolidate duplicate logging into shared SecurityHelpers module

[WilliamBerryiii]

Summary

Consolidates duplicate logging functions into the shared SecurityHelpers.psm1 module, eliminating code duplication across security scripts.

Closes #321

Changes

SecurityHelpers.psm1

• Import CIHelpers.psm1 for CI annotation support
• Add -CIAnnotation switch parameter to Write-SecurityLog for opt-in CI annotation forwarding (Warning/Error levels)
• Change Info color from White to Cyan to match script conventions

Test-DependencyPinning.ps1

• Import SecurityHelpers.psm1
• Remove local Write-PinningLog function (32 lines)
• Replace all ~25 Write-PinningLog call sites with Write-SecurityLog -CIAnnotation

Test-SHAStaleness.ps1

• Import SecurityHelpers.psm1
• Remove local Write-SecurityLog function (33 lines)
• Add $PSDefaultParameterValues to route OutputFormat and LogPath parameters transparently

Test files

• Update Test-DependencyPinning.Tests.ps1 mocks and context names from Write-PinningLog to Write-SecurityLog
• Add 4 CI annotation forwarding tests to SecurityHelpers.Tests.ps1

Validation

• Tests: 900 passed, 0 failed, 0 skipped
• Lint: 52 files analyzed, 0 issues

---

♻️ - Generated by Copilot

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

[Copilot]

Pull request overview

This PR successfully consolidates duplicate logging functions from multiple security scripts into a shared SecurityHelpers.psm1 module, eliminating code duplication and establishing a consistent logging pattern across the security tooling. The refactoring removes 65+ lines of duplicate code while maintaining backward compatibility through the use of $PSDefaultParameterValues for scripts that don't need CI annotation support.

Changes:

• Consolidated duplicate Write-PinningLog and Write-SecurityLog functions into a single shared implementation in SecurityHelpers.psm1 with opt-in CI annotation forwarding
• Updated Test-DependencyPinning.ps1 to use the shared function with -CIAnnotation switch for all ~25 call sites
• Updated Test-SHAStaleness.ps1 to use the shared function via $PSDefaultParameterValues for transparent parameter routing
• Updated test mocks and added 4 new tests validating CI annotation forwarding behavior

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
scripts/security/Modules/SecurityHelpers.psm1	Added CIHelpers import, -CIAnnotation switch parameter for opt-in CI annotation forwarding, and changed Info color from White to Cyan
scripts/security/Test-DependencyPinning.ps1	Removed 32-line local Write-PinningLog function, imported SecurityHelpers module, and updated ~25 call sites to use Write-SecurityLog -CIAnnotation
scripts/security/Test-SHAStaleness.ps1	Removed 33-line local Write-SecurityLog function, imported SecurityHelpers module, and added $PSDefaultParameterValues for transparent parameter routing
scripts/tests/security/Test-DependencyPinning.Tests.ps1	Updated mock function names from Write-PinningLog to Write-SecurityLog and updated context descriptions
scripts/tests/security/SecurityHelpers.Tests.ps1	Added 4 new tests validating CI annotation forwarding behavior for Warning, Error, and Info levels

[codecov-commenter]

Codecov Report

❌ Patch coverage is 76.47059% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.39%. Comparing base (cc92ef9) to head (56e8ff3).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
scripts/security/Test-DependencyPinning.ps1	70.37%	8 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #655      +/-   ##
==========================================
+ Coverage   85.37%   85.39%   +0.01%     
==========================================
  Files          23       23              
  Lines        4657     4641      -16     
==========================================
- Hits         3976     3963      -13     
+ Misses        681      678       -3     

Flag	Coverage Δ
pester	85.39% <76.47%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
scripts/security/Modules/SecurityHelpers.psm1	95.88% <100.00%> (+0.07%)	⬆️
scripts/security/Test-SHAStaleness.ps1	67.93% <100.00%> (-0.23%)	⬇️
scripts/security/Test-DependencyPinning.ps1	82.70% <70.37%> (-0.49%)	⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.