add markdown rendering for tables in popout #7299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mscolnick
reviewed
Nov 25, 2025
| parts: ContentPart[]; | ||
| }) => { | ||
| if (isMarkdown(content)) { | ||
| return <MarkdownRenderer content={content} />; |
Contributor
There was a problem hiding this comment.
this still runs on every cell, right?
Contributor
There was a problem hiding this comment.
we could make <PopoutColumn> take a renderContent instead of children and track when the popout is open and do {isOpen ? renderContent() : null}
Contributor
Author
There was a problem hiding this comment.
This only runs when the cell is clicked and the popout is opened. Radix's popover only renders the content on open.
But it has to be a component, previously I did not use a custom component and it would call on every cell.
Thanks for the other comments, I agree. And we can also merge this after release for safety.
mscolnick
reviewed
Nov 25, 2025
mscolnick
reviewed
Nov 25, 2025
mscolnick
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This was missed in the earlier PR because it was a branch of another branch.
This doesn't support all flavours of markdown, so some styling is missed.
🔍 Description of Changes
📋 Checklist