fix popout columns logic for long strings #7201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mscolnick
previously approved these changes
Nov 20, 2025
![cursor[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
|
|
||
| return commonMarkdownIndicators.some((type) => | ||
| tokens.some((token) => token.type === type), | ||
| ); |
There was a problem hiding this comment.
Bug: isMarkdown fails to detect inline markdown
The isMarkdown function checks only top-level tokens from marked.lexer, failing to detect inline markdown elements like strong, em, and link which are typically nested within paragraph tokens. This causes long strings with only inline markdown to render as raw text instead of rendered markdown in popout columns.
Light2Dark
force-pushed
the
sham/fix-table-long-string-popout
branch
from
de7ea45 to
e793f9b
Compare
mscolnick
approved these changes
Nov 21, 2025
4 tasks
mscolnick
pushed a commit
that referenced
this pull request
Nov 25, 2025
## 📝 Summary <!-- Provide a concise summary of what this pull request is addressing. If this PR fixes any issues, list them here by number (e.g., Fixes #123). --> This was missed in the [earlier PR ](#7201) because it was a branch of another branch. This doesn't support all flavours of markdown, so some styling is missed. <img width="395" height="381" alt="image" src="https://github.com/user-attachments/assets/f54d1eb7-bcca-47d3-9356-fad6317909e3" /> <img width="421" height="402" alt="image" src="https://github.com/user-attachments/assets/fb9c26d4-d51f-4595-88e3-998701c86993" /> ## 🔍 Description of Changes <!-- Detail the specific changes made in this pull request. Explain the problem addressed and how it was resolved. If applicable, provide before and after comparisons, screenshots, or any relevant details to help reviewers understand the changes easily. --> ## 📋 Checklist - [x] I have read the [contributor guidelines](https://github.com/marimo-team/marimo/blob/main/CONTRIBUTING.md). - [ ] For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on [Discord](https://marimo.io/discord?ref=pr), or the community [discussions](https://github.com/marimo-team/marimo/discussions) (Please provide a link if applicable). - [x] I have added tests for the changes made. - [x] I have run the code and verified that it works as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Issue where long strings didn't show up as popout columns, because they had markup. Also increases the width of popout columns and ensures they are truncated when inline for a clean table look.
before:
Screen.Recording.2025-11-18.at.10.39.02.PM.mov
after:
Screen.Recording.2025-11-18.at.10.38.03.PM.mov
🔍 Description of Changes
📋 Checklist
Note
Improves table cell rendering by detecting markdown and using a markdown renderer in popouts, refines long-string popout logic, adds copy-to-clipboard and layout tweaks, and updates tests and smoke demos.
w-96); usemax-w-fittrigger; apply wrapping styles; add copy-to-clipboard control in popout header.isMarkdown(viamarked) andMarkdownUrlDetectorto render markdown withMarkdownRendererin popouts; keepUrlDetectorfor non-markdown.allMarkupcheck; pass wrapped state consistently; minor class adjustments.isMarkdowntest suite; extendurl-detectortests.streamdowndeps in Vitest server config.tables/markdown_example.pyand updatetables/rich_elements.py(new long text with URLs, formatting).Written by Cursor Bugbot for commit de7ea45. This will update automatically on new commits. Configure here.