Skip to content

Conversation

@kevinthecheung
Copy link
Contributor

No description provided.

pavelgj and others added 30 commits May 1, 2024 15:27
Add tests that read JSON files that describe flows and expected results.

The goal is to run these tests for each genkit language, to make
sure all implementations behave the same.

There is currently a single test, whose expected trace came from
writing the flow in ts and calling `genkit flow:run`. This test
found a couple of bugs and discrepancies in the Go code, which are
also fixed here.

For #354.
Propagates the trace sampled state to the correct field in GCP logs
Update Devtools page and add some images and gifs
---------

Co-authored-by: Kevin Cheung <kevinthecheung@users.noreply.github.com>
Add a guide for writing a plugin that exports telemetry data.

---------

Co-authored-by: Konstantin Mandrika <kmandrika@users.noreply.github.com>
Co-authored-by: Kevin Cheung <kevinthecheung@users.noreply.github.com>
Add a link to the API dashboard which lists all APIs
enabled for a project.
Updated Genkit's  getting started with firebase guide to include an "npm init -y" command in the project setup.
* More visual get-started

* fix link
pavelgj and others added 22 commits May 1, 2024 15:27
)

* Align Go and TS metric names. Change the separator to '/' from'.'.
* Update docs on custom extractors

* Update evaluation.md

* Kevin fix

Co-authored-by: Kevin Cheung <kevinthecheung@users.noreply.github.com>

* Kevin fix

Co-authored-by: Kevin Cheung <kevinthecheung@users.noreply.github.com>

* Update docs/evaluation.md

Co-authored-by: Kevin Cheung <kevinthecheung@users.noreply.github.com>

* Update docs/evaluation.md

Co-authored-by: Kevin Cheung <kevinthecheung@users.noreply.github.com>

* Update docs/evaluation.md

Co-authored-by: Kevin Cheung <kevinthecheung@users.noreply.github.com>

* Update docs/evaluation.md

Co-authored-by: Kevin Cheung <kevinthecheung@users.noreply.github.com>

---------

Co-authored-by: Pavel Jbanov <pavelj@google.com>
Co-authored-by: Kevin Cheung <kevinthecheung@users.noreply.github.com>
Ran these commands:
    go get -u google.golang.org/api
    go mod tidy

Fixes #232
Change the name of the action latency histogram from
"genkit.action.action_latency" to "genkit.action.latency"
to avoid stutter.
* Added Go support to `genkit start`.

* Added graceful shutdown of dev server.

* Formatting.

* Update utils.ts

* Update init.ts
…s follow the convention {pluginName}/{actionName} (#253)
@kevinthecheung kevinthecheung requested a review from pavelgj May 1, 2024 21:31
@pavelgj pavelgj force-pushed the main branch 2 times, most recently from c5838f8 to dca1561 Compare May 1, 2024 23:56
Copy link
Collaborator

@tonybaroneee tonybaroneee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR needs to be recreated from scratch.

@kevinthecheung kevinthecheung deleted the kevinthecheung-patch-1 branch May 7, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment