Add strong response types for vertex evaluators #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schnecle
approved these changes
May 1, 2024
tonybaroneee
approved these changes
May 1, 2024
pavelgj
force-pushed
the
main
branch
2 times, most recently
from
c5838f8 to
dca1561
Compare
pavelgj
pushed a commit
that referenced
this pull request
May 1, 2024
Display errors in the Prompt Playground component after receiving issues from backend
Also update styles for running + error statues in output box.
Input validation for prompt playground
Also add icons for all known action types
Co-authored-by: Chris Chestnut <cchestnut@google.com> Co-authored-by: Michael Doyle <michaeldoyle@google.com>
Fixes google/genkit#130. This is more of a stop-gap fix, going to explore refactoring these components to utilize Angular signals to eliminate this class of error entirely.
Change the name of the action latency histogram from "genkit.action.action_latency" to "genkit.action.latency" to avoid stutter.
tagboola
force-pushed
the
ta/vertex-evals-strong-types
branch
from
7e16a96 to
983658f
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point, we should rely on the generated API client. In the short term, this will hopefully prevent issues like we saw before.