etcdctl: add verbose flag to check perf cmd #20816
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow to get more detail on the perf check: proposal to add a new verbose flag relying on the already existing
reportpackage to get histogram/distribution ont the perf check executed (whereas it fails or not)This allow to get more information than just slowest/stddev if wanted.
Example
etcdctl check perf --verbose:Success:
Failure:
How to test
make buildbin/etcdbin/etcdctl check perf --verbose