Skip to content

etcdctl: add verbose flag to check perf cmd #20816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −0
Open

etcdctl: add verbose flag to check perf cmd #20816

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
etcdctl: add verbose flag to check perf cmd 
To allow to get more detail on the perf check, a new verbose
flag is added relying on the already existing report package.

Signed-off-by: Baptiste Lalanne <baptiste.lalanne@datadoghq.com>
  • Loading branch information
@BaptisteLalanne
BaptisteLalanne committed Oct 19, 2025
commit 1645a5e829a6b8435c66cda580a3b681d24f1938
8 changes: 8 additions & 0 deletions etcdctl/ctlv3/command/check.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ var (
checkDatascalePrefix string
autoCompact bool
autoDefrag bool
verbose bool
)

type checkPerfCfg struct {
Expand Down Expand Up @@ -130,6 +131,7 @@ func NewCheckPerfCommand() *cobra.Command {
cmd.Flags().StringVar(&checkPerfPrefix, "prefix", "/etcdctl-check-perf/", "The prefix for writing the performance check's keys.")
cmd.Flags().BoolVar(&autoCompact, "auto-compact", false, "Compact storage with last revision after test is finished.")
cmd.Flags().BoolVar(&autoDefrag, "auto-defrag", false, "Defragment storage after test is finished.")
cmd.Flags().BoolVarP(&verbose, "verbose", "v", false, "Print detailed performance report.")
cmd.RegisterFlagCompletionFunc("load", func(_ *cobra.Command, _ []string, _ string) ([]string, cobra.ShellCompDirective) {
return []string{"small", "medium", "large", "xLarge"}, cobra.ShellCompDirectiveDefault
})
Expand Down Expand Up @@ -216,10 +218,12 @@ func newCheckPerfCommand(cmd *cobra.Command, args []string) {
}()

sc := r.Stats()
rc := r.Run()
wg.Wait()
close(r.Results())

s := <-sc
rp := <-rc

attemptCleanup(clients[0], autoCompact)

Expand All @@ -229,6 +233,10 @@ func newCheckPerfCommand(cmd *cobra.Command, args []string) {
}
}

if verbose {
fmt.Print(rp)
}

ok = true
if len(s.ErrorDist) != 0 {
fmt.Println("FAIL: too many errors")
Expand Down