Skip to content

Simplify logic in varmap #1594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Simplify logic in varmap #1594

merged 1 commit into from
Jul 25, 2022

Conversation

basepi
Copy link
Contributor

@basepi basepi commented Jul 22, 2022

What does this pull request do?

I merged #1593 before following up on #1592 -- @kohlmanj-hs had an excellent recommendation there to simplify my logic from #1593. Thus, this PR.

@apmmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-22T16:52:06.096+0000

  • Duration: 29 min 12 sec

Test stats 🧪

Test Results
Failed 0
Passed 4922
Skipped 3455
Total 8377

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /test linters : Run the Python linters only.

  • /test full : Run the full matrix of tests.

  • /test benchmark : Run the APM Agent Python benchmarks tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@apmmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (68/68) 💚
Files 100.0% (227/227) 💚
Classes 100.0% (227/227) 💚
Lines 89.641% (17255/19249) 👍 0.021
Conditionals 76.869% (3147/4094) 👍 0.098
Copy link
Contributor

@beniwohli beniwohli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@basepi basepi merged commit 04bea0a into elastic:main Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants