Fix can disconnected issue #514 #518
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
per1234
added
type: imperfection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disable the error interrupt conditions for canfd, it aims to fix issue #514.
When interrupt conditions are enabled the error isr is continuously firing preventing the application to run: in particular when the CAN is completely disconnected it seems that application is completely frozen, while instead it is continuously handling the same error isr.
Disabling the error conditions is the simplest way to avoid that: the write function will detect problems and returns error, giving the application the possibility to run.
With this change it has been observed that occasionally the write function does not return an error when the CAN bus is disconnected. This seems to be an acceptable compromise.