Repository navigation
iOS: full keyboard keys, Hex key, and recording panel (experiment) - #914
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behind the
experiments.fullKeyboardflag from #910 (off by default), the Hex keyboard becomes a full QWERTY keyboard on iPhone:123, space, the Hex key, return. With the flag off, the dictation bar mounts exactly as today;KeyboardSurface.swiftis untouched.Before: the Hex keyboard is a 140 pt dictation bar; you switch keyboards to type.
After (flag on):
Colours follow the field's
keyboardAppearancefirst, then the system style. After an insertion, an "Undo dictation" chip takes it back until the next edit. Suggestions and autocorrect are PR 3.Simulator stills (letters, 123, recording, light, dark, and a dark field in a light app) were reviewed outside this PR.
Read: 13 engine tests (rollover, slide, shift chord and lock, 123 hold-slide, double-space, word delete, email and number fields) pass on an iOS 18 simulator with the PR 1 suites (40 total). Not yet tried on a device.