Skip to content

Add support for offerSession #5410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 12, 2023
Merged

Add support for offerSession #5410

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ac29977
Add support for offerSession
cabanier Dec 11, 2023
e173bb9
simplify offerSession implementation
cabanier Dec 11, 2023
a03d112
Address review comments
cabanier Dec 12, 2023
94488f7
Address review comments
cabanier Dec 12, 2023
d1a057f
handle self.usedOfferSession state properly
cabanier Dec 12, 2023
e44bd2b
fix build problem
cabanier Dec 12, 2023
4fd2c88
Address review comment
cabanier Dec 12, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
handle self.usedOfferSession state properly
  • Loading branch information
@cabanier
cabanier committed Dec 12, 2023
commit d1a057fe55b211050161304f5db03dab0f951528
7 changes: 5 additions & 2 deletions src/core/scene/a-scene.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ class AScene extends AEntity {

// Don't enter VR if already in VR.
if (useOfferSession && navigator.xr.offerSession === undefined) { return Promise.resolve('OfferSession is not supported.'); }
if (self.usedOfferSession) { return Promise.resolve('OfferSession was already called.'); }
if (self.usedOfferSession && useOfferSession) { return Promise.resolve('OfferSession was already called.'); }
if (this.is('vr-mode')) { return Promise.resolve('Already in VR.'); }

// Has VR.
Expand All @@ -302,7 +302,10 @@ class AScene extends AEntity {
requestSession(xrMode, xrInit).then(
function requestSuccess (xrSession) {
self.xrSession = xrSession;
self.usedOfferSession = false;

if (useOfferSession) {
self.usedOfferSession = false;
Copy link
Member

@dmarcos dmarcos Dec 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably can always set this to false here?
Copy link
Member

@dmarcos dmarcos Dec 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without checking useOfferSession
Copy link
Contributor Author

@cabanier cabanier Dec 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the regular requestSession API will then also set this to false. At that point we'll be in a bad state because the offersession promise is still pending.
}

vrManager.layersEnabled = xrInit.requiredFeatures.indexOf('layers') !== -1;
vrManager.setSession(xrSession).then(function () {
Expand Down