Add support for offerSession #5410

cabanier · 2023-12-11T21:54:30Z

offerSession is a recent addition to WebXR that makes it more obvious that a page can enter WebXR.
Quest browser got feedback that the "Enter VR/AR/XR" buttons on a lot of sites is hard to find.
Often the button is small or scrolled of the bottom of the page. To remedy this, we worked with the W3C Immersive group on a new API that adds a button to the URL bar. This button will launch a pending immersive session.

This change will call offerSession when the page is opened or when the immersive session exits.

cc @dmarcos

dmarcos · 2023-12-11T22:08:45Z

src/components/scene/xr-mode-ui.js

    } else {
      if (!utils.device.checkVRSupport()) { this.enterVREl.classList.add('fullscreen'); }
      this.enterVREl.classList.remove(HIDDEN_CLASS);
+      sceneEl.enterVR(false, true);


We should probably handle this a bit differently. Give control to the dev and decide if the page is auto-entering VR. Maybe a property in this component enterImmersiveModeAtPageLoad a tad long but descriptive. open to a shorter alternative. We can then probably handled the sceneEl.enterVR here https://github.com/aframevr/aframe/pull/5410/files#diff-8eae4e9d86bc7d08e7db133212411b40a655722a0d8c42c1c99c45fccef72f74L124 before deciding to display the UI

src/core/scene/a-scene.js

src/components/scene/xr-mode-ui.js

src/core/scene/a-scene.js

dmarcos · 2023-12-12T01:07:30Z

src/core/scene/a-scene.js

              self.xrSession = xrSession;
+
+              if (useOfferSession) {
+                self.usedOfferSession = false;


Probably can always set this to false here?

without checking useOfferSession

I believe the regular requestSession API will then also set this to false. At that point we'll be in a bad state because the offersession promise is still pending.

src/core/scene/a-scene.js

Add support for offerSession

ac29977

cabanier marked this pull request as ready for review December 11, 2023 21:54