-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Better shader docs #3154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Better shader docs #3154
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
c024413
Update material.md
machenmusik 2f67e5a
Update material.md
machenmusik 47e22ec
Update material.md
machenmusik 6a370ca
Update material.md
machenmusik 8d0c325
Update material.md
machenmusik 948b2e2
Update material.md
machenmusik a387b47
Create shaders.md
machenmusik d6ac66a
Update shaders.md
machenmusik d0c268d
Update shaders.md
machenmusik b2459d1
Update shaders.md
machenmusik c3fc4d2
Update shaders.md
machenmusik a451ab4
Update material.md
machenmusik 072cda2
Update material.md
machenmusik 50966cd
Update material.md
machenmusik 392f796
Update material.md
machenmusik 9653524
remove separate shaders section per discussion on PR
machenmusik 948b3d1
aframe-shadertoy-gallery is gone
machenmusik 16ae6e5
add examples in header
machenmusik 27c6ddb
[docs] add don's displacement shader example to material docs
ngokevin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update material.md
- Loading branch information
commit 6a370ca1343218b2cd2194fb63dfc99fda7299d7
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the Glitch demos can be listed in the
examplesarray in the header:For ease of copy/pasting, I'd remove the GLSLify build step and use multiline strings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was that way originally (using GLSL-ify) so I left it that way; you can see that the new one I added as walkthrough does, in fact, use multi-line strings. Are you asking to make changes to the existing example instances that will retroactively alter documentation for prior versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remix the Glitch and not alter the old one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI - current examples header looks pretty unattractive, and no other good examples to follow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a data structure, it gets rendered underneath the table of contents as a list. I think there are two Glitches you listed, can add more as we go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checked, there are more than two. Good list!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated the Glitches I made, just the page and script, no more extraneous server and files