Skip to content

FORMS-18646: Desktop, RWD Tablet, RWD Mobile - State: Expand/collapse state of the element is missing or incorrect @sunnym @vavarshn #1741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
+9 −1
Open

FORMS-18646: Desktop, RWD Tablet, RWD Mobile - State: Expand/collapse state of the element is missing or incorrect @sunnym @vavarshn #1741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6899002
FORMS-18646: Desktop, RWD Tablet, RWD Mobile - State: Expand/collapse…
Oct 27, 2025
c36250d
FORMS-18646: Add test case for expanded state
Nov 24, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...n/content/jcr_root/apps/core/fd/components/af-commons/v1/fieldTemplates/questionMark.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<template data-sly-template.questionMark="${@ componentId, longDescription, bemBlock}">
<button class="${bemBlock}__questionmark" data-sly-test="${longDescription}" title="Help text">
Copy link
Contributor

@im-shiv im-shiv Nov 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is it's open by default? we can show short description by default, it should be conditional
Copy link
Contributor Author

@stefan-dragomir stefan-dragomir Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I initially tied the aria-expanded attribute to the state of Long Description, which is always initiated as "false".

But, if the short description is showing by default, and the Long Description is still initiated as Hidden, how should I treat the Aria Expanded behavior? When is it True and when is it False?
Because, on click, it only switches between Short and Long description. Is it always Expanded? Is it Expanded only when Short Description is showing? Is it Expanded only when Long Description is showing?
<button class="${bemBlock}__questionmark" data-sly-test="${longDescription}" aria-expanded="false" title="Help text">
</button>
</template>
2 changes: 2 additions & 0 deletions ui.frontend/src/view/FormFieldBase.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -707,11 +707,13 @@ class FormFieldBase extends FormField {
if (tooltipAlwaysVisible) {
self.#showHideTooltipDiv(false);
}
questionMarkDiv.setAttribute('aria-expanded', true);
} else {
self.#showHideLongDescriptionDiv(false);
if (tooltipAlwaysVisible) {
self.#showHideTooltipDiv(true);
}
questionMarkDiv.setAttribute('aria-expanded', false);
}
});
}
Expand Down
6 changes: 6 additions & 0 deletions ui.tests/test-module/libs/support/commands.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -655,6 +655,9 @@ Cypress.Commands.add("toggleDescriptionTooltip", (bemBlock, fieldId, shortDescri
//initially long description should have data-cmp-visible="false" to avoid flickering on page load
cy.get(`#${fieldId}`).find(`.${bemBlock}__longdescription`).invoke('attr', 'data-cmp-visible')
.should('eq', 'false');
// check if questiionmark is collapsed
cy.get(`#${fieldId}`).find(`.${bemBlock}__questionmark`).invoke('attr', 'aria-expanded')
.should('eq', 'false');
// click on ? mark
cy.get(`#${fieldId}`).find(`.${bemBlock}__questionmark`).click();
// long description should be shown
Expand All @@ -665,6 +668,9 @@ Cypress.Commands.add("toggleDescriptionTooltip", (bemBlock, fieldId, shortDescri
// short description should be hidden.
cy.get(`#${fieldId}`).find(`.${bemBlock}__shortdescription`).invoke('attr', 'data-cmp-visible')
.should('eq', 'false');
// check if questiionmark is expanded
cy.get(`#${fieldId}`).find(`.${bemBlock}__questionmark`).invoke('attr', 'aria-expanded')
.should('eq', 'true');
});

Cypress.Commands.add("openSidePanelTab", (tab) => {
Expand Down
Loading