Skip to content

FORMS-18646: Desktop, RWD Tablet, RWD Mobile - State: Expand/collapse state of the element is missing or incorrect @sunnym @vavarshn #1741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

FORMS-18646: Desktop, RWD Tablet, RWD Mobile - State: Expand/collapse state of the element is missing or incorrect @sunnym @vavarshn #1741

wants to merge 2 commits into from

Conversation

@stefan-dragomir
Copy link
Contributor

@stefan-dragomir stefan-dragomir commented Oct 27, 2025 •
edited
Loading

Description

Related Issue

https://jira.corp.adobe.com/browse/FORMS-18646

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Screen.Recording.2025-10-27.at.16.21.12.mov

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.
FORMS-18646: Desktop, RWD Tablet, RWD Mobile - State: Expand/collapse…
6899002 
… state of the element is missing or incorrect @sunnym @vavarshn
im-shiv
im-shiv reviewed Nov 20, 2025
View reviewed changes
...main/content/jcr_root/apps/core/fd/components/af-commons/v1/fieldTemplates/questionMark.html
@@ -1,4 +1,4 @@
<template data-sly-template.questionMark="${@ componentId, longDescription, bemBlock}">
<button class="${bemBlock}__questionmark" data-sly-test="${longDescription}" title="Help text">
Copy link
Contributor

@im-shiv im-shiv Nov 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is it's open by default? we can show short description by default, it should be conditional
Copy link
Contributor Author

@stefan-dragomir stefan-dragomir Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I initially tied the aria-expanded attribute to the state of Long Description, which is always initiated as "false".

But, if the short description is showing by default, and the Long Description is still initiated as Hidden, how should I treat the Aria Expanded behavior? When is it True and when is it False?
Because, on click, it only switches between Short and Long description. Is it always Expanded? Is it Expanded only when Short Description is showing? Is it Expanded only when Long Description is showing?
im-shiv
im-shiv requested changes Nov 20, 2025
View reviewed changes
Copy link
Contributor

@im-shiv im-shiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, add test cases for both the scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@stefan-dragomir @im-shiv