Skip to content

[Strings] Add a string-builtins feature, and lift/lower automatically when enabled #7601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

[Strings] Add a string-builtins feature, and lift/lower automatically when enabled #7601

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
5db98f4
start
kripken May 15, 2025
36d89d5
work
kripken May 15, 2025
956d45a
docs
kripken May 15, 2025
b72d753
p
kripken May 15, 2025
3b21cf2
format
kripken May 15, 2025
adad0dc
work
kripken May 15, 2025
c636685
work
kripken May 15, 2025
7bf1cf7
finish
kripken May 15, 2025
8ad61b5
Merge remote-tracking branch 'origin/main' into sb
kripken May 15, 2025
48f05f7
test
kripken May 15, 2025
60637f9
test
kripken May 15, 2025
3195ac2
test
kripken May 15, 2025
4dd6747
test
kripken May 16, 2025
3c29e7b
use magic imports [ci skip]
kripken May 16, 2025
8ae39b8
Merge remote-tracking branch 'origin/main' into sb
kripken May 16, 2025
bbd6804
gate the pass behind GC
kripken May 16, 2025
2e82f9a
update test
kripken May 16, 2025
0feeeae
work
kripken May 16, 2025
02d1d23
update exact result in test, likely because of the new pass we run
kripken May 16, 2025
57ac595
so many tests to update
kripken May 16, 2025
00b3c1b
fix feature reading
kripken May 19, 2025
123b879
fix unit test
kripken May 19, 2025
dfa5231
gc is needed too, now, for string optimization
kripken May 19, 2025
77b7f6e
fix: some tests have type updates due to another pass being run
kripken May 19, 2025
17c5019
simplify test as suggested
kripken May 19, 2025
0a447e5
don't fuzz string builtins yet
kripken May 19, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
so many tests to update
  • Loading branch information
@kripken
kripken committed May 16, 2025
commit 57ac595a3a66030c14811da8b9f3dac4b7c67edf
2 changes: 1 addition & 1 deletion test/example/c-api-kitchen-sink.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ BinaryenFeatureMemory64: 2048
BinaryenFeatureRelaxedSIMD: 4096
BinaryenFeatureExtendedConst: 8192
BinaryenFeatureStrings: 16384
BinaryenFeatureAll: 4194303
BinaryenFeatureAll: 8388607
(f32.neg
(f32.const -33.61199951171875)
)
Expand Down
Loading