Skip to content

[Strings] Add a string-builtins feature, and lift/lower automatically when enabled #7601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
don't fuzz string builtins yet
  • Loading branch information
kripken committed May 19, 2025
commit 0a447e58df4a97af7a94a97db74de06e4686c0fb
12 changes: 10 additions & 2 deletions scripts/fuzz_opt.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,16 @@
# parameters

# feature options that are always passed to the tools.
# XXX fp16 is not yet stable, remove from here when it is
CONSTANT_FEATURE_OPTS = ['--all-features', '--disable-fp16']
CONSTANT_FEATURE_OPTS = [
'--all-features',
# TODO fp16 is not yet stable, remove from here when it is
'--disable-fp16',
# TODO if we enable string-builtins then if the input module has strings,
# the output after lowering will have string imports, and the
# interpreter does not yet support executing those (we'd need to handle
# all the imported functions, magic constants, and the section)
'--disable-string-builtins',
]

INPUT_SIZE_MIN = 1024
INPUT_SIZE_MEAN = 40 * 1024
Expand Down
Loading