Skip to content

Embind port #7239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 38 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test
  • Loading branch information
kripken committed Mar 29, 2024
commit 82fb2c9948792b3e85ef17c70d9be68b914b1272
13 changes: 7 additions & 6 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,8 @@ if(EMSCRIPTEN)
add_link_flag("-sNODERAWFS")
endif()
# in opt builds, LTO helps so much (>20%) it's worth slow compile times
#add_nondebug_compile_flag("-flto")
add_nondebug_compile_flag("-flto")
add_compile_flag("-DEMSCRIPTEN_HAS_UNBOUND_TYPE_NAMES=0") # XXX - ?
endif()

# clang doesn't print colored diagnostics when invoked from Ninja
Expand Down Expand Up @@ -542,25 +543,25 @@ if(EMSCRIPTEN)

# binaryen.embind.js variant (WebAssembly)
add_executable(binaryen_embind_wasm
src/binaryen_embind.cpp
src/binaryen-embind.cpp
${binaryen_emscripten_SOURCES})
target_link_libraries(binaryen_embind_wasm wasm asmjs emscripten-optimizer passes ir cfg support analysis parser wasm)
target_link_libraries(binaryen_embind_wasm "-sFILESYSTEM")
target_link_libraries(binaryen_embind_wasm "-sEXPORT_NAME=Binaryen")
#target_link_libraries(binaryen_embind_wasm "-sEXPORT_NAME=Binaryen")
target_link_libraries(binaryen_embind_wasm "-sNODERAWFS=0")
# Do not error on the repeated NODERAWFS argument
target_link_libraries(binaryen_embind_wasm "-Wno-unused-command-line-argument")
# Emit a single file for convenience of people using binaryen.js as a library,
# so they only need to distribute a single file.
target_link_libraries(binaryen_embind_wasm "-sSINGLE_FILE")
target_link_libraries(binaryen_embind_wasm "-sEXPORT_ES6")
#target_link_libraries(binaryen_embind_wasm "-sSINGLE_FILE")
#target_link_libraries(binaryen_embind_wasm "-sEXPORT_ES6")
target_link_libraries(binaryen_embind_wasm "--bind")
target_link_libraries(binaryen_embind_wasm "-msign-ext")
target_link_libraries(binaryen_embind_wasm "-mbulk-memory")
#target_link_libraries(binaryen_embind_wasm optimized "--closure=1")
# TODO: Fix closure warnings! (#5062)
target_link_libraries(binaryen_embind_wasm optimized "-Wno-error=closure")
#target_link_libraries(binaryen_embind_wasm optimized "-flto")
target_link_libraries(binaryen_embind_wasm optimized "-flto")
target_link_libraries(binaryen_embind_wasm debug "--profiling")
install(TARGETS binaryen_embind_wasm DESTINATION ${CMAKE_INSTALL_BINDIR})
endif()
Expand Down
5 changes: 5 additions & 0 deletions src/binaryen-embind.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,9 @@
#include "wasm.h"

using namespace wasm;
using namespace emscripten;

EMSCRIPTEN_BINDINGS(Binaryen) {
class_<Expression>("Expression")
.function("finalize", &Expression::finalize);
}