Skip to content

Embind port #7239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 38 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
work
  • Loading branch information
kripken committed Apr 1, 2024
commit 6fcbbef50f7d00789144967e5c92e5285e131821
4 changes: 3 additions & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -548,20 +548,22 @@ if(EMSCRIPTEN)
target_link_libraries(binaryen_embind_wasm "-sFILESYSTEM")
#target_link_libraries(binaryen_embind_wasm "-sEXPORT_NAME=Binaryen")
target_link_libraries(binaryen_embind_wasm "-sNODERAWFS=0")
target_link_libraries(binaryen_embind_wasm "-sMODULARIZE")
# Do not error on the repeated NODERAWFS argument
target_link_libraries(binaryen_embind_wasm "-Wno-unused-command-line-argument")
# Emit a single file for convenience of people using binaryen.js as a library,
# so they only need to distribute a single file.
#target_link_libraries(binaryen_embind_wasm "-sSINGLE_FILE")
#target_link_libraries(binaryen_embind_wasm "-sEXPORT_ES6")
target_link_libraries(binaryen_embind_wasm "--bind")
target_link_libraries(binaryen_embind_wasm "-lembind")
target_link_libraries(binaryen_embind_wasm "-msign-ext")
target_link_libraries(binaryen_embind_wasm "-mbulk-memory")
#target_link_libraries(binaryen_embind_wasm optimized "--closure=1")
# TODO: Fix closure warnings! (#5062)
target_link_libraries(binaryen_embind_wasm optimized "-Wno-error=closure")
#target_link_libraries(binaryen_embind_wasm optimized "-flto")
target_link_libraries(binaryen_embind_wasm optimized "--profiling") # XXX
target_link_libraries(binaryen_embind_wasm optimized "-O1") # XXX
target_link_libraries(binaryen_embind_wasm debug "--profiling")
install(TARGETS binaryen_embind_wasm DESTINATION ${CMAKE_INSTALL_BINDIR})
endif()
Expand Down